Skip to content

TPC TimeSeries: provide TRD tracklets in anchored MC workflow- Reference O2-7264 - #2532

Closed
miranov25 wants to merge 1 commit into
AliceO2Group:masterfrom
miranov25:mcfix
Closed

miranov25 wants to merge 1 commit into
AliceO2Group:masterfrom
miranov25:mcfix

Conversation

@miranov25

Copy link
Copy Markdown
Contributor

The anchored-MC TPC TimeSeries task consumes TRD-matched tracks and
requests the TRD calibrated tracklet input TRD/CTRACKLETS/0.

However, the o2-global-track-cluster-reader feeding the TimeSeries task
was configured with:

--cluster-types "FT0,TOF,TPC"

so no producer for TRD/CTRACKLETS/0 was present in the generated workflow.

This caused workflow validation to fail with:

[ERROR] invalid workflow in o2-tpc-time-series-workflow:
No matching output found for TRD/CTRACKLETS/0
as requested by data processor "tpc-time-series".

The fix is deliberately minimal:

--cluster-types "FT0,TOF,TPC"
->
--cluster-types "FT0,TOF,TPC,TRD"

No track-source selection or other MC workflow configuration is changed.

This affects anchored MC productions with TPC TimeSeries enabled through
ADDTIMESERIESINMC.

Validation:

  • python -m py_compile MC/bin/o2dpg_sim_workflow.py passes.
  • Functional change is limited to the TimeSeries reader --cluster-types
    configuration.

Branch: miranov25:mcfix
Commit: 9936e59

Add TRD to the cluster types requested by the global track/cluster
reader feeding the TPC TimeSeries task.

The TimeSeries workflow consumes ITS-TPC-TRD-TOF tracks and therefore
requests TRD calibrated tracklets. Without TRD in --cluster-types,
the workflow has no producer for TRD/CTRACKLETS/0 and fails workflow
validation before execution.

Keep the existing TimeSeries track-source selection and all other MC
workflow settings unchanged.

Validation:
- Python syntax check passed
- functional change limited to adding TRD to the TimeSeries reader
  --cluster-types list
@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@miranov25 miranov25 changed the title TPC TimeSeries: provide TRD tracklets in anchored MC workflow TPC TimeSeries: provide TRD tracklets in anchored MC workflow- Reference O2-7264 Nov 2, 2026
@miranov25

Copy link
Copy Markdown
Contributor Author

Reference JIRA:
https://its.cern.ch/jira/browse/O2-7264

@alcaliva
alcaliva enabled auto-merge (squash) November 2, 2026 14:37
@miranov25

Copy link
Copy Markdown
Contributor Author

Hello @sawenzel and @jackal1-66,

Could you please approve and merge the modification? It is a single line that enables TRD tracklets in the MC production for the time series.

We need it for:
https://its.cern.ch/jira/browse/O2-7264

It is blocking time series productions.

@alcaliva

alcaliva commented Nov 3, 2026

Copy link
Copy Markdown
Collaborator

Hi @jackal1-66 and @sawenzel,
could you please have a look and if you agree merge?
Thanks!

@miranov25

Copy link
Copy Markdown
Contributor Author

Hi @jackal1-66 and @sawenzel,

Could you please have a look, and if you agree, merge? It is a one-line change: adding TRD to the input.

Thanks!

@sawenzel

sawenzel commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

I am testing an alternative approach since we should not add detector names statically. This will fail immediately, the moment TRD is not part of a data-taking run. Rather I propose to follow up on #2141 and make the input detector list fully dynamic. Testing it right now.

@sawenzel sawenzel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose to hold this PR and follow up with a more flexible/dynamic path.

@sawenzel
sawenzel disabled auto-merge November 4, 2026 15:01
sawenzel added a commit to sawenzel/O2DPG that referenced this pull request Nov 4, 2026
This makes the TPC time-series task in the MC workflow take its inputs from the active detectors.

- The reader used fixed cluster types without TRD, so the time series failed with "No matching output found for TRD/CTRACKLETS/0" once it requested TRD tracklets.
- Track and cluster types now come from cleanDetectorInputList.
- The same track list goes to o2-tpc-time-series-workflow via --track-sources, if the async software supports it.
- TOF and TRD are optional, and the task requires ITS, TPC and FT0.

https://its.cern.ch/jira/browse/O2-7264
AliceO2Group#2532

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@miranov25

Copy link
Copy Markdown
Contributor Author

@sawenzel

Do you expect my one-line fix to fail for the specific production currently blocked in O2-7264?

We have a production under preparation blocked now:
https://its.cern.ch/jira/browse/O2-7264

If the dynamic solution is not yet ready for production, I suggest enabling TRD with this minimal fix for the current production and replacing it with the general dynamic solution afterwards.

Is your dynamic solution ready to be used for this production now?

Please give me a short answer: yes or no.

@alcaliva , @catalinristea - when do you plan to start MC production O2-7264 ? I assume preparation is almost ready?

sawenzel added a commit to sawenzel/O2DPG that referenced this pull request Nov 4, 2026
This fixes the TRD/CTRACKLETS failure of the TPC time-series task in the MC workflow and makes its inputs follow the active detectors.

- The reader used fixed cluster types without TRD, so the time series failed with "No matching output found for TRD/CTRACKLETS/0" once it requested TRD tracklets.
- Track types now follow the active detectors and the anchored TRD and TOF matching sources.
- The same track list goes to o2-tpc-time-series-workflow via --track-sources.
- Builds with their own readers get --disable-root-input, so only one reader list exists.
- TOF and TRD are optional, and the task requires ITS, TPC and FT0.
- Builds without --track-sources keep the previous command and require TOF and TRD.

https://its.cern.ch/jira/browse/O2-7264
AliceO2Group#2532

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
sawenzel added a commit that referenced this pull request Nov 4, 2026
This fixes the TRD/CTRACKLETS failure of the TPC time-series task in the MC workflow and makes its inputs follow the active detectors.

- The reader used fixed cluster types without TRD, so the time series failed with "No matching output found for TRD/CTRACKLETS/0" once it requested TRD tracklets.
- Track types now follow the active detectors and the anchored TRD and TOF matching sources.
- The same track list goes to o2-tpc-time-series-workflow via --track-sources.
- Builds with their own readers get --disable-root-input, so only one reader list exists.
- TOF and TRD are optional, and the task requires ITS, TPC and FT0.
- Builds without --track-sources keep the previous command and require TOF and TRD.

https://its.cern.ch/jira/browse/O2-7264
#2532

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sawenzel

sawenzel commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

I merged #2141. A new tag will be prepared if tests on tomorrows daily succeed.

@sawenzel sawenzel closed this Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants