From b0fdeb6bbba226a8054596cb72042baee4d850f8 Mon Sep 17 00:00:00 2001 From: SDL-A1 <313604962+SDL-A1@users.noreply.github.com> Date: Wed, 18 Nov 2026 13:58:58 +0000 Subject: [PATCH] Move past the lettre STARTTLS and dot-stuffing advisories cargo-deny's advisories check failed on three RUSTSEC advisories published against lettre 0.11.23, which the smtp feature builds into rustock-alerts and so into the node binary: - RUSTSEC-2026-0560: a man-in-the-middle appends replies to the cleartext reply to STARTTLS, and the client takes them for the server's replies to the commands it then sends over TLS. A message the server rejected can be made to look accepted. Only STARTTLS connections are affected (Tls::Required and Tls::Opportunistic, as `starttls_relay` sets up, which `TlsMode::Starttls` selects in crates/alerts/src/sink.rs); implicit TLS is not. - RUSTSEC-2026-0561: missing dot-stuffing after a bare LF or CR allows SMTP command injection. - A panic on an EHLO reply line of only white space, a denial of service. All three are fixed in 0.11.24. `cargo update -p lettre` takes email-encoding 0.4.3 with it, which carries the dot-stuffing fix. Lockfile only: no manifest changes, and the package count is unchanged at 469, with nothing added or removed beyond those two versions. Cargo's re-resolution also moves errno, rustix and tempfile from windows-sys 0.52.0 to 0.61.2; both were already locked, and both remain. `cargo metadata --locked` passes and every dependency outside the workspace still carries a checksum (459 of 469, the other 10 being the workspace members), which is what the Security workflow asserts. Found by the advisories job on #374, not by the daily schedule in security.yml: that cron has never fired since it was added on 11 September 2026 (0 scheduled runs repository-wide). Filed separately. Co-Authored-By: Claude Opus 5 --- Cargo.lock | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/Cargo.lock b/Cargo.lock index 5a5916c..9f14cfc 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1403,9 +1403,9 @@ dependencies = [ [[package]] name = "email-encoding" -version = "0.4.2" +version = "0.4.3" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "420b9da095f052ea597503e39073b5b3c522f7db933fbac202d91d24492693fd" +checksum = "9f690ae2169f2ceb3f45b28b6fcd8fa16839f2f5c8818546774b9425f5f71004" dependencies = [ "base64 0.23.1", "memchr", @@ -1450,7 +1450,7 @@ source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "39cab71617ae0d63f51a36d69f866391735b51691dbda63cf6f96d042b63efeb" dependencies = [ "libc", - "windows-sys 0.52.0", + "windows-sys 0.61.2", ] [[package]] @@ -2139,9 +2139,9 @@ checksum = "bbd2bcb4c963f2ddae06a2efc7e9f3591312473c50c6685e1f298068316e66fe" [[package]] name = "lettre" -version = "0.11.23" +version = "0.11.24" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "f2c646bd5cc763b1087b15493e29a64be6147ba8f19342004fa52048ee596eae" +checksum = "f294f3d7cdb313e578acef7d7727d4e8d897e0fcd0d6d58c19959cec95073f19" dependencies = [ "async-trait", "base64 0.23.1", @@ -3220,7 +3220,7 @@ dependencies = [ "errno", "libc", "linux-raw-sys", - "windows-sys 0.52.0", + "windows-sys 0.61.2", ] [[package]] @@ -3945,7 +3945,7 @@ dependencies = [ "getrandom 0.3.4", "once_cell", "rustix", - "windows-sys 0.52.0", + "windows-sys 0.61.2", ] [[package]]