Repository navigation
fix(mcp): say why a tool is missing in read-only mode - #307
Merged
Merged
Conversation
With --read-only, dcd mcp asks the hosted server for its read-only tools, and the server then doesn't list the others at all. A call to one of them, such as run, came back as a bare "Unknown tool: run". In read-only mode an unknown tool now says the server offers only the tools that change nothing. The test stand-in for the hosted server now honours ?read_only=true as the API does, which is how this slipped through. A second test plays an API that lists every tool, so the local refusal stays covered.
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With --read-only, dcd mcp asks the hosted server for its read-only tools, and the server then doesn't list the others at all. A call to one of them, such as run, came back as a bare "Unknown tool: run". In read-only mode an unknown tool now says the server offers only the tools that change nothing.
The test stand-in for the hosted server now honours ?read_only=true as the API does, which is how this slipped through. A second test plays an API that lists every tool, so the local refusal stays covered.
What & why
Type of change
fix— bug fixfeat— new featureperf— performance improvementrefactor— code change that's neither a fix nor a featuredocs— documentation onlychore/ci/build/test— tooling, no user-facing change!or PR notes aBREAKING CHANGE:)Checklist
pnpm lintpassespnpm typecheckpassespnpm buildpassesCHANGELOG.md(the release workflow handles this)README.md/STYLE_GUIDE.mdupdated if behaviour or output changedHow to test