Skip to content

Commit f80beaf

Browse files
Kninsayclaude
andauthored
CI: pin Playwright for the audit, move to Node 22 (#8)
The audit step failed on GitHub because playwright was not a dependency. Pin it to the exact version used locally so the browser build matches. Node 20 is past end of life; build on Node 22 here and on Cloudflare Pages. Claude-Session: https://claude.ai/code/session_01Gnmfunw3PUpLkhSGZWPpfn Co-authored-by: Claude <noreply@anthropic.com>
1 parent de353fd commit f80beaf

5 files changed

Lines changed: 37 additions & 6 deletions

File tree

‎.github/workflows/site.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ jobs:
4949
run: npm run build
5050
- name: Accessibility, CSP and page-weight audit
5151
run: |
52-
npx --yes playwright@1 install --with-deps chromium
52+
npx playwright install --with-deps chromium # version pinned in package.json
5353
npm run audit
5454
- name: Validate the Caddy config
5555
run: docker run --rm -v "$PWD/deploy/hetzner/Caddyfile:/etc/caddy/Caddyfile:ro" caddy:2 caddy validate --adapter caddyfile --config /etc/caddy/Caddyfile

‎.node-version‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
20
1+
22

‎deploy/README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ Workers & Pages, Create, Pages, **Connect to Git**, choose `djoleradikod/djonko.
194194
| Environment variables, Production | `SITE_URL` = `https://djonko-dev.pages.dev` (until launch) |
195195
| Environment variables, Preview | none. Preview builds take their own address from `CF_PAGES_URL`. |
196196

197-
Node comes from `.node-version` (20). Under Settings, Build, keep the build system at version 3.
197+
Node comes from `.node-version` (22). Under Settings, Build, keep the build system at version 3.
198198

199199
Under Settings, Build, **Branch control**: production deployments on for `main`; preview deployments for
200200
**Custom branches**, include `*`, exclude `dependabot/*`. Dependabot pull requests are checked by the GitHub

‎package-lock.json‎

Lines changed: 31 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎package.json‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"version": "0.2.0",
55
"private": true,
66
"engines": {
7-
"node": ">=20"
7+
"node": ">=22"
88
},
99
"scripts": {
1010
"dev": "astro dev",
@@ -33,6 +33,7 @@
3333
"satori": "^0.18.4"
3434
},
3535
"devDependencies": {
36-
"axe-core": "^4.14.0"
36+
"axe-core": "^4.14.0",
37+
"playwright": "1.63.0"
3738
}
3839
}

0 commit comments

Comments
 (0)