From ff8292f6da7cf749565ed9a92902f1cbe14a2e63 Mon Sep 17 00:00:00 2001 From: Andrei Borza Date: Fri, 13 Nov 2026 10:12:10 +0100 Subject: [PATCH 1/6] chore: Restore previous PR template and agent PR rules Co-Authored-By: Claude Opus 5.5 --- .github/PULL_REQUEST_TEMPLATE.md | 27 ++++++--------------------- AGENTS.md | 4 +++- 2 files changed, 9 insertions(+), 22 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index d12cda804156..c935a1665d3c 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,23 +1,8 @@ - - -**Why:** - -**How to review:** - -**Unsure about:** - -Closes # - - +Closes #issue_link_here diff --git a/AGENTS.md b/AGENTS.md index 28fcc07f144a..490af7040cdd 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -59,7 +59,9 @@ Uses **Git Flow** (see `docs/gitflow.md`). ## Pull Requests -- Use `.github/PULL_REQUEST_TEMPLATE.md` for the body (`gh pr create --body` skips it). Ideally 1-2 sentences per field, no AI walkthrough. +- **Do NOT add a "Test plan" / "Testing" checklist to PR bodies.** CI runs the full test suite on every PR — a hand-rolled checklist duplicates that signal and rots fast. Write the summary content directly and add a _Root cause_ section only if relevant. +- **Omit the "Summary" heading** in PR bodies — lead with the summary text itself, no `## Summary` header. +- Include `Fixes #` somewhere in the PR body so the merge auto-closes the linked issue. - Always open PRs as draft. - Never apply the `Accept Bundlesize Increase` label. - **Keep PR descriptions condensed** — usually a few sentences. Explain the _reasoning_: why the change is needed, and any non-obvious decisions or tradeoffs made along the way. Do **not** walk through the implementation or describe what changed file-by-file — the diff already shows that. Only go longer when the decisions genuinely warrant it. From fe9c578c58de8ed6dfe60ebe2314fb1694d6cf07 Mon Sep 17 00:00:00 2001 From: Andrei Borza Date: Fri, 13 Nov 2026 10:15:40 +0100 Subject: [PATCH 2/6] Keep AGENTS.md PR rules unchanged --- AGENTS.md | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/AGENTS.md b/AGENTS.md index 490af7040cdd..28fcc07f144a 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -59,9 +59,7 @@ Uses **Git Flow** (see `docs/gitflow.md`). ## Pull Requests -- **Do NOT add a "Test plan" / "Testing" checklist to PR bodies.** CI runs the full test suite on every PR — a hand-rolled checklist duplicates that signal and rots fast. Write the summary content directly and add a _Root cause_ section only if relevant. -- **Omit the "Summary" heading** in PR bodies — lead with the summary text itself, no `## Summary` header. -- Include `Fixes #` somewhere in the PR body so the merge auto-closes the linked issue. +- Use `.github/PULL_REQUEST_TEMPLATE.md` for the body (`gh pr create --body` skips it). Ideally 1-2 sentences per field, no AI walkthrough. - Always open PRs as draft. - Never apply the `Accept Bundlesize Increase` label. - **Keep PR descriptions condensed** — usually a few sentences. Explain the _reasoning_: why the change is needed, and any non-obvious decisions or tradeoffs made along the way. Do **not** walk through the implementation or describe what changed file-by-file — the diff already shows that. Only go longer when the decisions genuinely warrant it. From 38e3dbb8140745be91c2404b64b5cfa48c1873f9 Mon Sep 17 00:00:00 2001 From: Andrei Borza Date: Fri, 13 Nov 2026 13:15:57 +0100 Subject: [PATCH 3/6] Use What/Why structure in PR template --- .github/PULL_REQUEST_TEMPLATE.md | 22 ++++++++++++++++------ 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index c935a1665d3c..b460917634fb 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,8 +1,18 @@ -Before submitting a pull request, please take a look at our -[Contributing](https://github.com/getsentry/sentry-javascript/blob/develop/CONTRIBUTING.md) guidelines and verify: +## What -- [ ] If you've added code that should be tested, please add tests. -- [ ] Ensure your code lints and the test suite passes (`pnpm run lint`) & (`pnpm run test`). -- [ ] Link the related issue. External contributors need a maintainer's go-ahead in that issue. + -Closes #issue_link_here +## Why + + + +Closes: # + + From 6609c0886e0194eda967778256f56970035c74c0 Mon Sep 17 00:00:00 2001 From: Andrei Borza Date: Fri, 13 Nov 2026 13:21:22 +0100 Subject: [PATCH 4/6] Move general guidance to the top of the PR template --- .github/PULL_REQUEST_TEMPLATE.md | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index b460917634fb..e6711e78b23d 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,3 +1,9 @@ + + ## What Closes: # - - From b887fa39f7aecae51f63a05dfe1f291ba4d92730 Mon Sep 17 00:00:00 2001 From: Andrei <168741329+andreiborza@users.noreply.github.com> Date: Fri, 13 Nov 2026 13:46:13 +0100 Subject: [PATCH 5/6] Update .github/PULL_REQUEST_TEMPLATE.md Co-authored-by: Sigrid <32902192+s1gr1d@users.noreply.github.com> --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index e6711e78b23d..350df0bf3e80 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -13,6 +13,6 @@ Describe behavior and intent, not implementation. Reviewers read the diff for th ## Why - + Closes: # From df9efab3da3ab43777fd7bab5d2ad56d6166a0f5 Mon Sep 17 00:00:00 2001 From: Andrei Borza Date: Fri, 13 Nov 2026 13:46:37 +0100 Subject: [PATCH 6/6] Keep the external contributor note in the PR template --- .github/PULL_REQUEST_TEMPLATE.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index e6711e78b23d..7fe2fd6f508f 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -2,6 +2,7 @@ Read the Contributing guidelines first: https://github.com/getsentry/sentry-javascript/blob/develop/CONTRIBUTING.md Use simple, direct sentences. No "Summary" heading, no test-plan checklist. Remove "Closes" if there is no linked issue. +External contributors: link an issue where you got a maintainer's go-ahead. --> ## What