Repository navigation
every event says breaking, deprecated or added; every kind emits additions - #257
Conversation
change replaces change_type and breaking: breaking stays breaking, deprecation is deprecated, new_feature is added; nothing emitted fix. The fingerprint hashes change where it hashed change_type, so every deprecation's fingerprint is new. Goldens regenerated: each event gets change in place of change_type and breaking, nothing else moves (958 events checked against main). contract/fixtures synced from patch-it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: adssib <75389300+adssib@users.noreply.github.com>
An adapter whose versions are published again after being named (adapter.Rereleased, Stripe) has the change into a version read from the version's first release, and what its later releases add filed under the version itself (previous_version = version), additions only. A pair of two releases of one version is additions only. New golden: stripe-api-additions.json, from real v2516/v2525/v2592 spec excerpts (the two enum values Stripe added inside 2026-09-30.endive). No existing golden moves. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: adssib <75389300+adssib@users.noreply.github.com>
…ameters are added events The surfaces compared for removals are compared the other way too, with the same care: a name the older release bound, couldn't read, or a method moved up to a base class isn't new; a new class's members are its addition; a TypeScript parameter is new only at the end with every older one in place. Goldens regenerated: 12 apisurface goldens gain their pairs' additions (82 added events); no breaking event moves. A drop pair may add: it must store nothing that breaks or deprecates. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: adssib <75389300+adssib@users.noreply.github.com>
… added events
A bullet under an Added or Features heading is read with the same care as
a removal: names added plainly ("Added `X` method", "Add `a` to `B`"),
or a parameter given a call ("Added `p` parameter to `f`"). A feature
told in words, names with no owner, a list mixing owned and bare names,
or a constant "to" a type is no event. A JSON changelog's endpoint-added
is an added event, unless the endpoint is coming back after a removal.
Goldens regenerated: 7 changelog goldens gain their releases' additions
(27 added events); no breaking or deprecated event moves.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: adssib <75389300+adssib@users.noreply.github.com>
A command file in the newer release's listing and not the older's is fetched at the newer tag and filed as added_symbol, quoting it; a command whose name leaves one file and arrives in another is a file moved: neither. redis-commands.json gains the 19 commands 8.8-rc1 adds (the array commands and INCREX), from their real files; the drop pair's 17 additions are added events and nothing breaks. GitHub's upcoming changes list removals only: no additions to read there. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: adssib <75389300+adssib@users.noreply.github.com>
|
Claude finished @adssib's task in 1m 45s —— View job ✅ Ready to merge once the patch-it contract change (C5.10) is in: the code builds, every test passes, the metadata and pages are updated, and every golden change is explained in the PR. I found no blocking bugs. Rules
BugsNone found. Things I traced and found correct:
Verified
Non-blocking
|
The hosted ingestion service compares the newest version again, as a pair of one version, when its release moves; openapi says yes for an adapter that re-releases (Stripe). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: adssib <75389300+adssib@users.noreply.github.com>
| // ("Added `Client.stream` method", "Add `a` and `b` to `Widget`", "New | ||
| // `foo` function", "`bar` was added"), or a parameter it gives a call | ||
| // ("Added `timeout` parameter to `Client.send`"). | ||
| addedActive = regexp.MustCompile(`(?i)^(?:added|adds|add|introduced|introduces|introduce|new)(?: support for)? (?:the |a |an )?(?:new )?(?:` + noun + ` )?` + list + `(?: ` + noun + `)?(?: (?:to|on|in) (?:the )?(?:` + noun + ` )?(§)(?: ` + noun + `)?)?$`) |
There was a problem hiding this comment.
Precision (non-blocking, worth a look): (?: support for)? lets a bullet like Added support for `pyproject.toml` or Add support for `brotli` match with a bare § and no noun. cleanName accepts both (pyproject.toml passes ident as a dotted name), so the event says "pyproject.toml was added in ". "Support for X" usually names something outside the package (a file format, an encoding, a library), not a symbol it now exports.
I didn't see this in the current goldens. Two possible fixes: require a noun when support for is present, or drop support for from the added templates and add a pinned drop case to parse_test.go.
…Gone returns the base class Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: adssib <75389300+adssib@users.noreply.github.com>
What this changes
Every event says what it does to code written against the version before it:
change=breaking|deprecated|added, as the change-event contract now has it (C5.10 in patch-it, the contract's owner). Additions are data too: every kind emits the ones it can see, with the same care as a removal.One commit per step, goldens regenerated in the commit that changes them:
every event says breaking, deprecated or addedchangereplaceschange_typeandbreaking(breaking→breaking,deprecation→deprecated,new_feature→added; nothing emittedfix). The fingerprint hasheschangewhere it hashedchange_type, so every deprecation's fingerprint is new. Every golden regenerated; nothing else moves (958 events compared with main).contract/fixtures/synced.openapi: what a re-released version adds inside itself is filed under itgolden/stripe-api-additions.json(below). No existing golden moves.apisurface: new modules, classes, functions, methods and optional parameters are added eventsaddedevents. No breaking event moves.changelog: "Added" and "Features" bullets that name what they add are added eventsaddedevents. No breaking or deprecated event moves.catalog: a command new in a release is an added eventredis-commands.jsongains the 19 commands 8.8-rc1 adds.Every regenerated golden was checked with a script: each event on main is still there with the same fields, its
changethe oldchange_typerenamed; what's new is onlyaddedevents.Per kind
oneOfmembers were already found by the differ; they're nowaddedevents. Providers whose spec history showed "new" operations were mostly moved or re-added ones (vercel, sentry, appwrite, and the otherDeprecationsOnlyfilters) keep dropping them, and their filters now say why (precision over recall). GitLab and Flagsmith (request side only) file request-side additions.adapter.Rereleased): the change into a version is read from the first release whoselatest/openapi.spec3.jsondeclares it, so nothing Stripe adds inside a version is filed with the changes between two versions; what the version's later releases add is filed under the version itself (previous_version=version), additions only. A pair of two releases of one version is additions only. Measured on real releases: 2026-08-26.dahlia (v2516) → 2026-09-30.endive gives the 64 breaking and 837 added changes between the versions, read from v2525, plus the two enum values Stripe added inside 2026-09-30.endive by v2526. The golden replays this on real spec excerpts (v2516, v2524, v2525, v2592: two schemas, values unchanged).added_parameter; a new required one stays a logged note (no subject for it).Client.streammethod", "AddatoB", "Addedtimeoutparameter toClient.send"). A feature told in words, names with no owner, a list mixing owned and bare names, a constant "to" a type, or "support forX" with nothing it's on is no event. A JSON changelog'sendpoint-addedis an addition, unless the endpoint is coming back after a removal.Drop tests
A drop test now means "nothing that breaks or deprecates": additions are expected there (the apisurface helper, the redis drop pair's 17 additions, the scaffolded drop fixtures, MongoDB's newest day with its one new endpoint).
Checklist
stripe/api's andredis/commands' "watches" now say they report additions; I read the words. The other sources' metadata didn't change.git commit -s, DCO)stripe/testdata/openapi/(spec excerpts),redis/testdata/redis-8.8-rc1-*.jsonandredis-8.10.0-*.json(whole command files)testdata/README.mdlists each new file (Stripe, Redis)providers/<provider>/README.mdupdated (Stripe, Redis, MongoDB, every apisurface and changelog section)providers/<provider>/; the kinds import no providerenv.Get/core/kit/(Stripe's adapter keeps its ownfetch.Get, as before)make checkpasses locally, andmake check PATCH_IT=<patch-it checkout of the contract change>(contract fixtures match)Notes for the reviewer
contract/fixtures/here is synced from that change, not from patch-it's main yet; CI_contract skips while patch-it isn't public.change(and to compare a re-released Stripe version's newer releases as a pair of one version). Until it bumps, it keeps the release it pins.notGonereturns the base class instead of the move-up check parsing its message. Not done: caching Stripe's releases listing per run (Releaseslists them again for each pair, asVersionsdoes per run).plugin.Rereleasing(core): a source says it re-releases versions, so the hosted ingestion service compares a version with itself at a newer release._as public, as removals always did.🤖 Generated with Claude Code