From 578f86f63cf8331e833449f9ec015ce73d8b8703 Mon Sep 17 00:00:00 2001 From: Chris Marchbanks Date: Fri, 30 Oct 2026 10:36:21 -0600 Subject: [PATCH] Pin pytest below 9.2 until pytest-benchmark is fixed pytest 9.2 removed Node._nodeid, which pytest-benchmark 5.3.0 still reads, so test_benchmark_text_string_to_metric_families errors at setup. The fix (ionelmc/pytest-benchmark#323) is merged but not yet released. Assisted-by: Claude Sonnet 5.5 Signed-off-by: Chris Marchbanks --- tox.ini | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tox.ini b/tox.ini index d7326324..8aab112a 100644 --- a/tox.ini +++ b/tox.ini @@ -5,7 +5,10 @@ envlist = coverage-clean,py{3.10,3.11,3.12,3.13,3.14,py3.10,3.10-nooptionals},co deps = asgiref coverage - pytest + # pytest 9.2 removed Node._nodeid, which pytest-benchmark 5.3.0 still reads: + # https://github.com/ionelmc/pytest-benchmark/issues/321 + # Drop the upper bound once a pytest-benchmark release includes the fix. + pytest<9.2 pytest-benchmark attrs {py3.10,pypy3.10}: twisted