Repository navigation
AArch64: make sure SP is 16-aligned at all times during Pallocframe - #617
Open
xavierleroy wants to merge 1 commit into
Open
xavierleroy wants to merge 1 commit into
xavierleroy wants to merge 1 commit into
Conversation
SP-relative accesses crash if SP mod 16 != 0. This could happen before when setting up the stack frame, in the case where the outgoing arguments area of the frame has size = 8 mod 16. Then, the store of the return address and the back link would take place with SP = 8 mod 16 and crash, before SP is further decreased to a multiple of 16. This commit avoids this problem by aligning the size of the outgoing arguments area to 16. Fixes: #614 Closes: #615
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SP-relative accesses crash if SP mod 16 != 0. This could happen before when setting up the stack frame, in the case where the outgoing arguments area of the frame has size = 8 mod 16. Then, the store of the return address and the back link would take place with SP = 8 mod 16 and crash, before SP is further decreased to a multiple of 16.
This commit avoids this problem by aligning the size of the outgoing arguments area to 16.
Fixes: #614
Closes: #615