Repository navigation
feat(telemetry): add default-on usage analytics and detached delivery - #76
Open
littleDogWang wants to merge 5 commits into
Open
littleDogWang wants to merge 5 commits into
littleDogWang wants to merge 5 commits into
Conversation
Add anonymous core-flow events, optional webpage attribution, Agent classification and bounded collector delivery. Honor live MCP opt-out and Retry-After, classify EOF as failure, and emit each init validation stage once. Include privacy documentation and regression coverage.
Contributor
|
Overall, I like the approach here, especially the effort to limit what's collected and exclude sensitive data. A few things I'd like us to revisit before merging:
I'd also like to verify the BFF/PostHog privacy configuration before we enable collection in a release. My preference is to keep basic operational analytics as frictionless as legally permissible, while giving developers clear controls and treating cross-session attribution separately. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add usage analytics for Recipes, init and project creation across shell and MCP. When a valid collector is configured, capture defaults to enabled with a first-use stderr notice and saved/runtime opt-out controls. Observe project creation at the shared call boundary so later setup failures do not overwrite a successful creation result.
Type of change
Public-contract impact
docs/automation.mdand the changelog.telemetryConsentfrom config andconsentfrom status.enablednow reports only the saved preference;captureActivecombines that preference with runtime opt-out and a valid local collector URL.transportConfigureddoes not prove remote availability.{"enabled":true,"consent":"unknown","transportConfigured":false,"captureActive":false}{"enabled":true,"transportConfigured":false,"captureActive":false}cli_project_create_completedevent per shared createProject call, including authentication/token refresh/retry and excluding later feature/config/scaffold work. Reuse, pre-call validation failures and dry-run do not create this event. Success counts successful calls, not a complete project ledger.Test plan
go test ./... -count=1.go vet, gofmt, error-code audit and generated command-doc checks.make lintpassed its available checks.golangci-lintis not installed locally; Makefile skips that executable.Documentation
Security checklist
Additional notes
The embedded collector URL remains empty. Merge does not enable production capture; no deployment or real PostHog ingestion has been verified. Actual PostHog acceptance of omitted uuid and query-visible generated UUIDs must be verified before activation.
Companion collector PR: https://github.com/AgoraLab/ssp-service/pull/62.