Repository navigation
Conversation
HIST()/CONST_STR() created, at every call site, a lambda, a local struct, an index_sequence expansion over the characters and a ConstStr<'a','b',...> type. They now produce ConstStr<"ab">: one type per distinct name, the hash still a static member computed once per name, and concatenation still at the type level, so names passed as function parameters keep working. Hashes are unchanged. 2,000 distinct names (a quarter concatenated with a directory) in a template instantiated twice, -O2: clang 21 3.76 s -> 1.90 s and 591 -> 238 MB peak; GCC 16 6.41 s -> 3.04 s and 602 -> 366 MB. Object size +6%. Needs AliceO2Group/O2Physics#18584, which updates the helpers that spelled out ConstStr<chars...>.
Collaborator
|
Error while checking build/O2/fullCI_slc9 for 6fd6d9d at 2026-11-05 09:30: Full log here. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HIST()/CONST_STR() created, at every call site, a lambda, a local struct, an
index_sequence expansion over the characters and a ConstStr<'a','b',...> type.
They now produce ConstStr<"ab">: one type per distinct name, the hash still a
static member computed once per name, and concatenation still at the type
level, so names passed as function parameters keep working. Hashes are
unchanged.
2,000 distinct names (a quarter concatenated with a directory) in a template
instantiated twice, -O2: clang 21 3.76 s -> 1.90 s and 591 -> 238 MB peak;
GCC 16 6.41 s -> 3.04 s and 602 -> 366 MB. Object size +6%.
Needs AliceO2Group/O2Physics#18584, which updates the helpers that spelled out
ConstStr<chars...>.