Repository navigation
[PWGEM] PhotonMeson: merge EventHistograms into EMPhotonEventCut - #18590
Open
mhemmer-cern wants to merge 2 commits into
Open
mhemmer-cern wants to merge 2 commits into
mhemmer-cern wants to merge 2 commits into
Conversation
mhemmer-cern
requested review from
alibuild,
amaringarcia,
dsekihat,
hscheid,
jokonig and
reygers
as code owners
November 4, 2026 14:28
|
O2 linter results: ❌ 0 errors, |
jokonig
previously approved these changes
Nov 4, 2026
jokonig
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me. Thanks a lot for the work!
This comment was marked as outdated.
This comment was marked as outdated.
Move the event QA histograms from Utils/EventHistograms.h into EMPhotonEventCut so the histograms use the cut's actual settings. EventHistograms.h is removed; all users now call the member functions addEventHistograms(), fillEventInfo<0|1>() and fillAccepted(). EMPhotonEventCut: - Add track and FT0C occupancy cuts (SetTrackOccupancyRange, SetFT0COccupancyRange), applied in IsSelected(). Default is no cut. Skipped at compile time if the event table has no occupancy columns. - Add an optional Q vector cut (SetRequireGoodQvec, SetQvecDetectors, SetQvecHarmonic, SetMaxQvec). Off by default and skipped at compile time if the event table has no Q vector columns. - hCollisionCounter: fill the occupancy bins (10, 11), add a "good Q vector" bin (14), move "accepted" to bin 15. The Z vertex bin now uses the configured range instead of a fixed |z| < 10 cm. - Fix: all tasks filled "accepted" at bin 12, which is the "EMC MB Readout" bin. New Utils/EventUtilities.h (namespace o2::aod::pwgem::pm::utils::event) with the QvecEstimator/Harmonics enums, getQvec(), isQvecGood() and compile-time checks for Q vector and occupancy columns. Tasks: - Pass the occupancy configurables to the event cut and remove the duplicated manual occupancy checks. Collision Filters are kept. - taskPi0FlowEMC, taskPhotonFlow, taskFlowReso: remove the local Q vector enums, getQvec switch, isQvecGood and getAllQvec, and enable the Q vector cut through the event cut. processPCMMixed in taskPi0FlowEMC now also applies the Q vector check, like the other mixed-event processes. - taskFlowReso: cfgTrackOccupancyMin/Max are now applied (they were defined but unused). - Call DefineEMEventCut() before booking the histograms in Pi0EtaToGammaGamma(MC).h and TaggingPi0(MC).h. - calibTaskEmc: remove the unused Q vector and harmonics enums.
mhemmer-cern
force-pushed
the
pm-event-selection
branch
from
November 5, 2026 07:32
c4d4a57 to
9312ae7
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the event QA histograms from Utils/EventHistograms.h into EMPhotonEventCut so the histograms use the cut's actual settings. EventHistograms.h is removed; all users now call the member functions addEventHistograms(), fillEventInfo<0|1>() and fillAccepted().
EMPhotonEventCut:
New Utils/EventUtilities.h (namespace o2::aod::pwgem::pm::utils::event) with the QvecEstimator/Harmonics enums, getQvec(), isQvecGood() and compile-time checks for Q vector and occupancy columns.
Tasks: