Skip to content

chore: purge comments from all remaining packages - #14811

Merged
dylanjeffers merged 1 commit into
chore/comment-purge-mobilefrom
chore/comment-purge-rest
Nov 21, 2026
Merged

dylanjeffers merged 1 commit into
chore/comment-purge-mobilefrom
chore/comment-purge-rest

Conversation

@dylanjeffers

Copy link
Copy Markdown
Contributor

Stacked on #14806 → #14802 → #14796. Merge in that order.

What

The last /delete-comment pass. It covers every package not yet purged: libs, identity-service, protocol-dashboard, sdk (non-public internals), harmony, embed, es-indexer, commands, create-audius-app, migrate-tool, docs, fixed-decimal, spl, eth, eslint-config-audius, distro and svgo.config.js. After this PR the repo has zero non-exempt comments and .comment-baseline.json is {}.

Category Blocks Lines Action
Tautology 2,312 4,391 deleted
Stale 122 324 deleted
Excuse 107 167 deleted, filed as #14807 (libs), #14808 (identity-service), #14809 (protocol-dashboard), #14810 (sdk/harmony/embed/tooling)
Decision record 353 884 deleted, moved into docs/adr/0028–0033 (one per package group)

Net effect on code: −5,762 / +281 lines.

Bugs found and confirmed in source

These are listed first in the issues:

Fixes to the earlier PRs in this stack

Verification

Compared against a pristine checkout of #14806:

  • tsc --noEmit in all 13 packages with a tsconfig: identical error set (146 pre-existing, from local dependency drift in protocol-dashboard, commands, sdk and fixed-decimal).
  • lint in every package with a lint script: no new errors.
  • sdk vitest: same result (1 pre-existing failing file, 31 passing).
  • Repo-wide directive counts are identical before and after (@ts-ignore, @ts-expect-error, eslint-disable, prettier-ignore, @format, globals, @deprecated, @__PURE__, webpackChunkName, istanbul).
  • npm run lint:comments passes with an empty baseline.

🤖 Generated with Claude Code

Deletes the last 2,894 non-exempt comment blocks (libs, identity-service,
protocol-dashboard, sdk internals, harmony, embed and tooling packages).
Decision records move to docs/adr/0028-0033. Excuses are tracked in
#14807-#14810. The baseline is now empty.

Restores 17 @deprecated JSDoc blocks the earlier purges removed and
exempts @deprecated tags and generator DO NOT EDIT headers.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@changeset-bot

changeset-bot Bot commented Nov 21, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: c3f858f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dylanjeffers
dylanjeffers merged commit aed6915 into chore/comment-purge-mobile Nov 21, 2026
34 checks passed
@dylanjeffers
dylanjeffers deleted the chore/comment-purge-rest branch November 21, 2026 16:02
dylanjeffers added a commit that referenced this pull request Nov 21, 2026
Removes every non-exempt code comment from the apps repo and adds a CI
ratchet so new ones fail. This PR now contains the folded stack: #14802
(web), #14806 (mobile) and #14811 (all remaining packages).

## Result

- **11,113 comment blocks removed**, about 23,800 lines of code.
- **Decision records** (2,139) moved into `docs/adr/0002`–`0033`, each
with a permalink to the original line.
- **Excuses** (363 TODOs/hacks) filed as grouped checklists, with
confirmed bugs listed first: #14793–#14795, #14798–#14801,
#14803–#14805, #14807–#14810.
- **Tautologies and stale comments** deleted.

## Ratchet

- `npm run lint:comments` (`scripts/comment-ratchet.cjs`) runs in
`.github/workflows/comments.yml`. `.comment-baseline.json` is now `{}`,
so any new non-exempt comment fails CI.
- Exempt:
- tool directives (`eslint-disable`, `@ts-*`, `prettier-ignore`,
`@format`, bundler pragmas, `globals`, test-env pragmas)
  - `@deprecated`
  - JSDoc type annotations in plain JS
  - generator "DO NOT EDIT" headers
  - public-API JSDoc in `sdk`, `harmony`, `fixed-decimal` and `spl`
- `examples/`, vendored `public/` and `*.min.js`, and generated SDK code
- Policy: [ADR 0001](docs/adr/0001-no-code-comments.md). The
`/delete-comment` skill (`.claude/skills/delete-comment/`) repeats the
process.

## Verification

Each pass was compared against a pristine checkout of its base:
- `tsc` and lint: identical error sets for every touched package.
- Tests: identical results for common, web and sdk.
- Directive counts: identical repo-wide.
- Mobile jest couldn't run locally (stale shared `node_modules`). It
runs in this PR's CI now that the stack targets `main`.

## Deploy note

Merging deploys identity-service and embed automatically. Both changes
are comment-only. Web and mobile go out with the next gate and OTA as
usual.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant