Repository navigation
chore: purge comments from all remaining packages - #14811
Merged
dylanjeffers merged 1 commit intoNov 21, 2026
Merged
Conversation
Deletes the last 2,894 non-exempt comment blocks (libs, identity-service, protocol-dashboard, sdk internals, harmony, embed and tooling packages). Decision records move to docs/adr/0028-0033. Excuses are tracked in #14807-#14810. The baseline is now empty. Restores 17 @deprecated JSDoc blocks the earlier purges removed and exempts @deprecated tags and generator DO NOT EDIT headers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
dylanjeffers
added a commit
that referenced
this pull request
Nov 21, 2026
Removes every non-exempt code comment from the apps repo and adds a CI ratchet so new ones fail. This PR now contains the folded stack: #14802 (web), #14806 (mobile) and #14811 (all remaining packages). ## Result - **11,113 comment blocks removed**, about 23,800 lines of code. - **Decision records** (2,139) moved into `docs/adr/0002`–`0033`, each with a permalink to the original line. - **Excuses** (363 TODOs/hacks) filed as grouped checklists, with confirmed bugs listed first: #14793–#14795, #14798–#14801, #14803–#14805, #14807–#14810. - **Tautologies and stale comments** deleted. ## Ratchet - `npm run lint:comments` (`scripts/comment-ratchet.cjs`) runs in `.github/workflows/comments.yml`. `.comment-baseline.json` is now `{}`, so any new non-exempt comment fails CI. - Exempt: - tool directives (`eslint-disable`, `@ts-*`, `prettier-ignore`, `@format`, bundler pragmas, `globals`, test-env pragmas) - `@deprecated` - JSDoc type annotations in plain JS - generator "DO NOT EDIT" headers - public-API JSDoc in `sdk`, `harmony`, `fixed-decimal` and `spl` - `examples/`, vendored `public/` and `*.min.js`, and generated SDK code - Policy: [ADR 0001](docs/adr/0001-no-code-comments.md). The `/delete-comment` skill (`.claude/skills/delete-comment/`) repeats the process. ## Verification Each pass was compared against a pristine checkout of its base: - `tsc` and lint: identical error sets for every touched package. - Tests: identical results for common, web and sdk. - Directive counts: identical repo-wide. - Mobile jest couldn't run locally (stale shared `node_modules`). It runs in this PR's CI now that the stack targets `main`. ## Deploy note Merging deploys identity-service and embed automatically. Both changes are comment-only. Web and mobile go out with the next gate and OTA as usual. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #14806 → #14802 → #14796. Merge in that order.
What
The last
/delete-commentpass. It covers every package not yet purged: libs, identity-service, protocol-dashboard, sdk (non-public internals), harmony, embed, es-indexer, commands, create-audius-app, migrate-tool, docs, fixed-decimal, spl, eth, eslint-config-audius, distro andsvgo.config.js. After this PR the repo has zero non-exempt comments and.comment-baseline.jsonis{}.docs/adr/0028–0033(one per package group)Net effect on code: −5,762 / +281 lines.
Bugs found and confirmed in source
These are listed first in the issues:
libsCreatorNode._makeRequestV2: dereferences the optionalstorageNodeSelectorin its catch block, so a failed request throws a TypeError that hides the real error (Tech debt from comment purge: packages/libs #14807).libsWeb3Manager: there is no identity fallback when the discovery relay returns null, soparseLogsthrows (Tech debt from comment purge: packages/libs #14807).protocol-dashboardServiceTable: calls a hook insiderenderRowbehind aneslint-disable(Tech debt from comment purge: packages/protocol-dashboard #14809).commandsaao.ts: block and unblock post to two different discovery hostnames (Tech debt from comment purge: sdk, harmony, embed and tooling packages #14810).identity-service: three old migrationdownsteps reference the deletedNotificationmodel (low impact, Tech debt from comment purge: packages/identity-service #14808).Fixes to the earlier PRs in this stack
@deprecatedJSDoc blocks that chore: purge code comments repo-wide, add comment ratchet #14796, chore(web): purge comments from packages/web #14802 and chore(mobile): purge comments from packages/mobile #14806 removed from common, web and mobile. TypeScript and editors read the tag, so it is now exempt.generateServicesConfig.tsrewrites them.Verification
Compared against a pristine checkout of #14806:
tsc --noEmitin all 13 packages with a tsconfig: identical error set (146 pre-existing, from local dependency drift in protocol-dashboard, commands, sdk and fixed-decimal).lintin every package with a lint script: no new errors.sdkvitest: same result (1 pre-existing failing file, 31 passing).@ts-ignore,@ts-expect-error,eslint-disable,prettier-ignore,@format,globals,@deprecated,@__PURE__,webpackChunkName,istanbul).npm run lint:commentspasses with an empty baseline.🤖 Generated with Claude Code