Repository navigation
Python: fix static arguments on methods and class constructors - #263
Conversation
(the unintentionally used borg design pattern)
|
@BHoMBot check core |
|
@Tom-Kingstone to confirm, the following actions are now queued:
There are 99 requests in the queue ahead of you. |
jamesramsden-bh
left a comment
There was a problem hiding this comment.
The original fix introduced this bug:
Every pandas Timestamp crashes when converted. bson_unix_ticks and json.dumps(..., cls=BHoMJSONEncoder) both raise TypeError: tz_convert() takes exactly 2 positional arguments (1 given), for timestamps with and without a timezone. This breaks saving any BHoM object that holds a timestamp, and nothing in the test suite covers it. The fix is date_time.tz_convert("UTC").
This has now been resolved, and automated tests passing. Happy to approve.
|
@BHoMBot check required |
|
@jamesramsden-bh to confirm, the following actions are now queued:
There are 550 requests in the queue ahead of you. |
|
@BHoMBot check ready-to-merge |
|
@Tom-Kingstone to confirm, the following actions are now queued:
There are 167 requests in the queue ahead of you. |
|
@BHoMBot check ready-to-merge |
|
@Tom-Kingstone to confirm, the following actions are now queued:
There are 162 requests in the queue ahead of you. |
NOTE: Depends on
Issues addressed by this PR
Closes #260
see issue, this fixes the problem where applicable across the toolkit.
Also fixed deprecation warnings for
datetime.utcnow()(as the method was being changed anyway) and fixed anywhere that it was being called directly with non timezone aware datetimes.Test files
run the python unit test scripts.
Changelog
Additional comments