Repository navigation
ci: run the unit suite against the installed wheel - #33
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
The job ran 7 named query tests (2 of the files' 22). With the same isolation it now runs all of tests/unit against the built wheel, so a module or data file the wheel leaves out fails CI whichever feature it belongs to, not only the query path. The wheel is installed with [dev,all] so the pandas and polars tests run instead of skipping. The source-import guards are unchanged. Locally: 1121 passed against the wheel, and deleting arc_client/management/diagnostics.py from the installed package fails the job at collection (exit 2). Renamed the script to scripts/check_wheel.py and the job to "Unit tests (installed wheel)" to match.
Member
|
Thanks @jallegri. We broadened this in 0679577: the job now runs all of
Renamed the script to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related: Basekick-Labs/arc#726.
Test plan