Repository navigation
Do not log the addresses of connection objects in ConnectionPool (apache/pulsar-client-cpp#628) - #2
Open
alexey-milovidov wants to merge 2 commits into
Open
alexey-milovidov wants to merge 2 commits into
alexey-milovidov wants to merge 2 commits into
Conversation
The connection reuse and stale connection logs printed the raw heap address of the connection object, which ends up in the host application logs (e.g. `system.text_log` in ClickHouse) and discloses the memory layout. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The change itself (do not log the addresses of connection objects in `ConnectionPool`) is already in the `clickhouse` branch as c162ff9. The merge takes the line wrapping of the upstream pull request, so that the fork does not diverge from upstream once it is merged there. apache#628 Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges the upstream pull request apache#628 into the
clickhousebranch.The change itself is already in
clickhouseas c162ff9. The only difference is the line wrapping thatclang-formatproduces upstream, so this pull request makes the fork identical to the upstream pull request inlib/ConnectionPool.ccand avoids a conflict when upstream merges it.Related: apache#628
Related: ClickHouse/ClickHouse#64184
🤖 Generated with Claude Code