Skip to content

Add a test for Message::hasEventTimestamp (apache/pulsar-client-cpp#631) - #4

Open
alexey-milovidov wants to merge 3 commits into
clickhousefrom
upstream-pr-631
Open

alexey-milovidov wants to merge 3 commits into
clickhousefrom
upstream-pr-631

Conversation

@alexey-milovidov

Copy link
Copy Markdown
Member

Merges the upstream pull request apache#631 into the clickhouse branch.

Message::hasEventTimestamp is already in clickhouse as ea5d830, and the library part of the upstream pull request is identical to it. This pull request adds the remaining part, the test MessageTest.testHasEventTimestamp.

Related: apache#631
Related: ClickHouse/ClickHouse#64184

🤖 Generated with Claude Code

alexey-milovidov and others added 3 commits November 13, 2026 23:38
`getEventTimestamp` returns 0 both when the producer set no event time and
when it explicitly set the Unix epoch. Add `hasEventTimestamp`, mirroring the
existing `hasPartitionKey`/`hasOrderingKey`, so callers can tell the two apart.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
`Message::hasEventTimestamp` is already in the `clickhouse` branch as
ea5d830. The merge adds the test from the upstream pull request,
`MessageTest.testHasEventTimestamp`.

apache#631

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants