Repository navigation
feat(skills): add codspeed-write-benchmarks skill - #621
not-matthias wants to merge 4 commits into
Conversation
[Low impact] The PR appears safe to merge; no new actionable issues were found. SummaryAdds
Reviews (2) · Last reviewed commit: "docs(plugin): mention benchmark writing ..." · Reviewed by Greptile |
Merging this PR will improve performance by 13.49%2 warnings
Performance Changes
Tip Curious why performance improved? Comment Comparing Footnotes
|
Agents writing or editing CodSpeed benchmarks had no guidance on what makes a benchmark valid: the existing skills cover harness setup and optimization, not benchmark design. The skill lists language-agnostic rules (measure only the code under test, keep inputs constant, isolate state, size per instrument, keep names stable), a tiered verify step (static review, one CodSpeed run checked through the MCP tools, reruns only for noisy benchmarks), maintenance tasks for renames and code changes, and short notes for Rust, Node.js, Python and the exec harness. Details link to the CodSpeed docs.
Both skills triggered on requests like 'create a benchmark', and setup-harness repeated a shorter version of the benchmark-writing rules. Narrow its description to first-time setup and replace Step 4 with workload selection plus a pointer to codspeed-write-benchmarks, so the rules live in one place.
Optimizing against a noisy or invalid benchmark produces gains that are not real. Tell the optimize skill to fix such benchmarks with codspeed-write-benchmarks before starting the loop.
List the new codspeed-write-benchmarks skill among the included skills in the plugin long description.
aee0b29 to
32c1427
Compare
TLDR: Agents had no guidance on writing valid CodSpeed benchmarks. This adds a compact skill with rules, a verify step and maintenance tasks, and points the existing skills at it.
New skill
codspeed-write-benchmarksExisting skills and plugin
codspeed-setup-harness: description narrowed to first-time setup, so both skills no longer trigger on "create a benchmark". Its benchmark-writing step now points to the new skill.codspeed-optimize: fix noisy or invalid benchmarks with the new skill before optimizing.plugin.json: long description mentions the new skill.Review notes
Fixes COD-4129