Skip to content

London | 26-ITP-May |Maharit Belai | Sprint 3| Alarmclock - #1554

Open
MaharitB wants to merge 4 commits into
CodeYourFuture:mainfrom
MaharitB:alarmclock
Open

MaharitB wants to merge 4 commits into
CodeYourFuture:mainfrom
MaharitB:alarmclock

Conversation

@MaharitB

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Task code

CYF-1098

Changelist

I have met all the criteria.

Questions

@MaharitB MaharitB added Reviewed Volunteer to add when completing a review with trainee action still to take. Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 20, 2026
Comment on lines +19 to +20
"jest": "^30.5.2",
"jest-environment-jsdom": "^30.5.2"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Jest packages are pinned with ^30.5.2, a version range that does not match a published Jest release. Installing these dependencies will fail; could you verify the versions before adding them?

To "like" or "dislike" this comment, please follow this link

Comment thread Sprint-3/alarmclock/alarmclock.js Outdated
.toString()
.padStart(2, "0")}:${(inputTime.value % 60).toString().padStart(2, "0")}`;

const toStop = setInterval(alarmCount, 1000);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens to the active countdown if Set Alarm is clicked again before it finishes?

To "like" or "dislike" this comment, please follow this link

Comment thread Sprint-3/alarmclock/alarmclock.js Outdated
const toStop = setInterval(alarmCount, 1000);

function alarmCount() {
if (inputTime.value == 0) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this condition do when Set Alarm is clicked with the number field left empty?

To "like" or "dislike" this comment, please follow this link

@cyf-ai-code-reviewer cyf-ai-code-reviewer Bot added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 20, 2026
@cyf-ai-code-reviewer

Copy link
Copy Markdown

The CYF AI review has left comments. It will only review a PR one time. When you have addressed these comments, please request review again and a volunteer will take a look.

@MaharitB MaharitB added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant