Skip to content

mkconcore exits 0 and writes an empty study when the GraphML has no nodes #700

Open

Description

@yadavchiragg

Running mkconcore on a GraphML with no nodes (an empty graph, or a file that is not GraphML at all) prints the normal progress messages, writes empty iport/oport files and exits with code 0.

Repro:
printf 'not xml' > bad.graphml
mkdir src
python3 mkconcore.py bad.graphml src out posix
echo $? # prints 0

This is what hid #666 (BOM read as 0 nodes), so a build looked successful but produced empty scripts. Proposal: print "No nodes found in " and exit 1. I have a fix with a test ready and will open a PR for it.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions