Skip to content

mkconcore exits 0 when a node's source file is missing from the source directory #702

Open

Description

@yadavchiragg

When a node references a source file that does not exist in the source directory, mkconcore logs "Script 'x.py' not found in sourcedir" but keeps going, generates an incomplete study and exits with code 0. CI and scripts calling mkconcore directly cannot detect the failure.

Repro: a two-node graph (a:a.py -> b:b.py) with only a.py present in the source dir.
python3 mkconcore.py w.graphml src out posix; echo $? # prints 0

Proposal: collect all missing sources, log them together and exit 1. Pulled containers (labels without a file extension) are not affected. concore build already checks for this; this makes the generator itself consistent. I have a fix and test ready.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions