Skip to content

mkconcore silently ignores nodes and edges when the label is not in the first <data> element #704

Open

Description

@yadavchiragg

mkconcore.py reads node labels with node.find('data', recursive=False), which only looks at the first child. yEd can write an empty (for example a description) before the that holds the graphics and the label, so those nodes are skipped without any message and the study is generated without them. Edges have the same pattern.

Examples in the repo: testsou/pretty.graphml, testsou/testshKM3.graphml and testsou/testsh1KM3.graphml. concore validate and concore inspect read these labels correctly (they search the whole node), so validate passes and the build produces a study with missing nodes.

Skipped nodes/edges were also only logged at debug level, so nothing was visible.

Proposal: look for the label in every child and log a warning (with the node or edge id) when a node or edge is skipped. I have a fix and tests ready.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions