Skip to content

mkconcore accepts spaces in node/edge names, then the generated build script breaks #709

Open

Description

@yadavchiragg

A node or edge name with a space (e.g. "PID Controller:pid.py" or an edge "my edge") is accepted by mkconcore, which exits 0. The generated build script is unquoted, so it splits the name: it creates directories "my" and "ctrl", and then fails with "cp: target 'ctrl/a.py': No such file or directory". ./build itself also exits 0, so nothing tells the user the study is broken.

Names with # or {} work; shell metacharacters like ; $ ( ) are already rejected by safe_name(). Space is the gap.

Proposal: reject spaces in node and edge names in safe_name() with a hint ("use '_' instead"). Paths (output directory) are unaffected. No sample workflow in the repo uses spaces in names. I have a fix and tests ready.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions