Skip to content

mkconcore: find labels in any <data> child and warn when nodes/edges are skipped - #705

Open
yadavchiragg wants to merge 1 commit into
ControlCore-Project:devfrom
yadavchiragg:fix/mkconcore-label-lookup
Open

yadavchiragg wants to merge 1 commit into
ControlCore-Project:devfrom
yadavchiragg:fix/mkconcore-label-lookup

Conversation

@yadavchiragg

Copy link
Copy Markdown

Fixes #704

mkconcore only looked at the first child of each node/edge. yEd can write an empty before the one holding the label (e.g. testsou/pretty.graphml), so those nodes and edges were skipped silently, while concore validate/inspect read the same file correctly.

  • Labels are now looked up in every child of a node/edge.
  • Skipped nodes/edges (no label, or an edge to a missing node) are logged as warnings with their ids instead of at debug level. The build still continues.

Added tests/test_mkconcore_skipped_elements.py (5 tests); the yEd-structure and warning tests fail without the change. The three affected sample files now build their nodes, and the other sample graphs produce no new warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant