Skip to content

mkconcore: reject spaces in node and edge names with a clear message - #710

Open
yadavchiragg wants to merge 1 commit into
ControlCore-Project:devfrom
yadavchiragg:fix/reject-spaces-in-names
Open

yadavchiragg wants to merge 1 commit into
ControlCore-Project:devfrom
yadavchiragg:fix/reject-spaces-in-names

Conversation

@yadavchiragg

@yadavchiragg yadavchiragg commented Nov 18, 2026 •

Copy link
Copy Markdown

Fixes #709

A node or edge name containing a space was accepted, but the generated build script is unquoted, so it split the name into separate directories and failed (cp: target 'ctrl/a.py': No such file or directory) while mkconcore and ./build both exited 0.

safe_name() now also rejects spaces for node/edge names and tells the user to use '_' instead. Directory paths are unaffected, and no sample workflow in the repo uses spaces in names.

Added tests/test_mkconcore_name_spaces.py: node and edge names with spaces are rejected with the hint (fail without the change); names without spaces and an output directory with spaces still build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant