Skip to content

Adding a 'gap' property to the array widget - #4009

Open
kathryn-baker wants to merge 3 commits into
ControlSystemStudio:masterfrom
kathryn-baker:master
Open

kathryn-baker wants to merge 3 commits into
ControlSystemStudio:masterfrom
kathryn-baker:master

Conversation

@kathryn-baker

Copy link
Copy Markdown
Contributor

Added a 'gap' property to the array widget to address #3945.

  • Moves the gap property into common widget properties to avoid duplication
  • updates TemplateInstance widget to import from common widget properties
  • default gap in ArrayWidget gap set to 0 to maintain consistency across existing screens
  • auto-calculates the number of widgets available in the given ArrayWidget box

Testing

Manual

Tested by building Phoebus and comparing Array widget instances between pre-change build and post:
image
Manual manipulation of the gap property changes the number of widgets displayed within the array and the size of the array widget

Automated

No existing tests for this aspect of the widgets (either array or template instance) so test files not modified. app-display tests all passed when building

logic copied from TemplateInstance
now shared across two widgets so this removes duplication
@kathryn-baker
kathryn-baker marked this pull request as draft November 4, 2026 12:48
@sonarqubecloud

sonarqubecloud Bot commented Nov 4, 2026

Copy link
Copy Markdown

@kathryn-baker
kathryn-baker marked this pull request as ready for review November 4, 2026 14:08

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant