Repository navigation
merge(jobs): rebuild the skill fixture from a cache skeleton - #53
Merged
Merged
Conversation
rust-cache deletes every file outside the build profiles before saving, but keeps the directories. CI therefore restores target/tmp/job_skill_repo as empty folders, `.git` included. skill_repo saw `.git` and reused it. git did not recognise the skeleton as a repository and climbed to the checkout's own repository, so 20 guards failed on main since 9560cd3 with "SKILL.md is not in commit <main's HEAD>". The fixture now tests for `.git/HEAD`. It prunes a skeleton by removing empty directories only, so it never deletes a repository that another test process has just placed. It also runs git with GIT_CEILING_DIRECTORIES, so a missing repository fails here instead of reading the checkout's. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainhas been red since 9560cd3 (#51, roadmap-only): 20 candler-core guards fail on CI with ".claude/skills/htn/SKILL.mdis not in commit <main's HEAD>". The code at #50, the last green run, is the same.Cause
Swatinem/rust-cachesavestarget/after deleting every file outside the build profiles. It keeps the directories (cleanup rule: "Files other thanCACHEDIR.TAGare removed").So the cache restores the shared fixture
target/tmp/job_skill_repoas empty folders,.gitincluded.skill_repo()only checked that.gitexists, so it reused the skeleton. git did not recognise the skeleton as a repository and searched upward until it reached the checkout's own repository.Fix (test support only)
.git/HEADis a file.GIT_CEILING_DIRECTORIESset to the scratch directory, so a missing repository fails at once instead of reading the checkout's.Evidence
With a planted skeleton in an in-repo
target/:-D warnings) are clean.This also unblocks #52, whose 21 failures share this cause.
🤖 Generated with Claude Code