Repository navigation
feat: track datafog-core 1.4.0 email-boundary defaults - #186
Merged
Merged
Conversation
Core 1.4.0's text-mode email scanning trims label syntax by default, so `email=alice@example.com` reports `alice@example.com` and quoted values drop the wrapping quote. This moves the reviewed Rust contract file to `rust-1.4.0.json` (no new deviations: every recorded case still matches, verified by running the observation harness against 1.4.0), raises the dependency floor, and resolves the `json-escaped` and `markdown-code-block` native-corpus divergences. `unicode-chinese-name` stays with a corrected reason: its corpus fixture contains literal `?` characters, which are valid local-part characters, so the reviewed expectation remains overlap-only. Also stops the local verification gap this exposed: the two async/optional dependency failures and one accuracy improvement are relative to an unmodified main in the same environment (11 failed there, 10 here).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
datafog-core1.4.0 (datafog-core#249, #250) trims label syntax in default text-mode email spans, soemail=alice@example.comreportsalice@example.com, quoted values drop the wrapping quote, andSUPPORT_EMAIL=labels stay out of the span. This PR puts the facade on that train:datafog-core>=1.4.0,<2(both the default extra and[rust]).tests/contracts/rust-1.4.0.jsonwithcore_version1.4.0. No new deviations: I rantests/rust_contract.py's observation harness against a real 1.4.0 wheel; all 76 in-scope cases still match their recorded expectations (3 detector-difference, 1 validation-difference, unchanged).json-escapedandmarkdown-code-blockdivergences resolve and are removed.unicode-chinese-namestays with a corrected reason — its corpus fixture contains literal?characters, which are valid RFC local-part characters, so the reviewed expectation remains overlap-only.Verification
pytest tests/test_rust_contract.py tests/test_detection_accuracy.py tests/test_contract_481.pywithDATAFOG_ACCURACY_BACKEND=rustand datafog-core 1.4.0 installed: 447 passed.