Repository navigation
Remove Gitter badges from translated README files - #1910
Merged
das-g merged 1 commit intoNov 12, 2026
Merged
Conversation
Gitter has been shut down and its links were already removed from the English README in 2794ec4, but the translations still embed the badge image. When building the epub, honkit downloads remote images, and badges.gitter.im times out from GitHub Actions runners, which breaks the Build and Deploy workflow on every push to master. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
das-g
approved these changes
Nov 12, 2026
Member
On Crowdin? Sure. Thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1909.
After it was merged, the deploy still failed, so I read the job log. The cause is not calibre:
3.72.129.101isbadges.gitter.im.honkit build(HTML) succeeds.honkit epubfails because in ebook mode honkit downloads remote images to embed them, and 19 translatedREADME.mdfiles still embed the Gitter badge, which times out from GitHub Actions runners.Change
Gitter has been shut down, and the English README already dropped these links in 2794ec4. This PR applies the same removal to the 19 translations: the badge under the title and the "chat with us on Gitter" paragraph. No other page in the book embeds a remote image.
Verification
In an
ubuntu:24.04container with calibre and Node 24, withbadges.gitter.impointed at an unreachable address to mimic the runner:master:honkit epubfails with the sameerror while generating page "README.md"honkit epubsucceeds and generates all 20 epubsNote: these are translated files that normally come from Crowdin. It may be worth removing the Gitter strings there as well, so a future sync doesn't bring them back.