Repository navigation
Add screen reader text to icon-only links in forms chapter - #1912
Open
anaschwendler wants to merge 1 commit into
Open
anaschwendler wants to merge 1 commit into
anaschwendler wants to merge 1 commit into
Conversation
The new post and edit post links only contained an SVG icon, so screen readers announced them without any meaningful name. Add a Bootstrap visually-hidden label to every snippet and briefly explain why. Refs DjangoGirls#1522 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new post and edit post links only contained an SVG icon, so screen readers announced them without any meaningful name. Add a Bootstrap visually-hidden label to every snippet and briefly explain why.
Refs #1522.
The "New post" and "Edit post" links in the Django Forms chapter only contain an SVG icon, so screen readers announce them as a link with no meaningful name.
Changes (English only, translations come from Crowdin)
<span class="visually-hidden">New post</span>/Edit postto every snippet with these icon links (8 snippets).visually-hiddenis the Bootstrap 5 utility class, and the tutorial already loads Bootstrap 5.3.3, so nothing changes visually.About the rest of #1522
<div>→<header>suggestion is already done: the templates use<header class="page-header">.The English book builds fine with
make build LANG=en, and the hidden labels show up in the generated HTML.@das-g