Repository navigation
Conversation
Fixes #1175. When a functor is partially applied, `Mod.unsuspend` keeps the oracle calls whose target is one of the remaining parameters. It compared the full target of the call with the parameter, so a call such as `S(M).kg`, whose target is `S(M)` and not `S`, was dropped even when `S` is a remaining parameter. The partial application then looked as if it made no call at all. In the example of the issue, the following module is accepted at `Adv`, whose `run` may call nothing: module (B (D : T) : Adv) (S : Sch) = { proc run() : unit = { S(M).kg(); } }. and so is the instantiation of `A <: Adv {-St}` by `B(M)`, which is enough to prove `false`. The filter now compares the functor of the target, as `get_oi_calls` already does when it computes the calls of a module. `ModTy.sig_of_mt` uses the same filter and is changed in the same way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1175.
When a functor is partially applied,
Mod.unsuspendkeeps the oraclecalls whose target is one of the remaining parameters. It compared the
full target of the call with the parameter, so a call such as
S(M).kg, whose target isS(M)and notS, was dropped even whenSis a remaining parameter.The partial application then looked as if it made no call at all. In
the example of the issue, the following module is accepted at
Adv,whose
runmay call nothing:and so is the instantiation of
A <: Adv {-St}byB(M), which isenough to prove
false.The filter now compares the functor of the target, as
get_oi_callsalready does when it computes the calls of a module.
ModTy.sig_of_mtuses the same filter and is changed in the same way.