Repository navigation
Float Node.js on the 24.x line instead of pinning 24.22.1 - #56
Closed
NicolasBonet wants to merge 1 commit into
Closed
NicolasBonet wants to merge 1 commit into
NicolasBonet wants to merge 1 commit into
Conversation
Contributor
Author
|
Closing for now: we haven't decided how to handle Node.js updates yet. See https://github.com/Expensify/Expensify/issues/696498 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Node.js now floats on the 24.x line instead of being pinned to 24.22.1, so patch releases, including security fixes, reach CI without a PR in every repo.
.nvmrcholds the major only (24), and the CircleCI config uses thecimg/node:24image instead ofcimg/node:24.22.1, so it runs the newest 24.x image.Fixed Issues
For https://github.com/Expensify/Expensify/issues/696498
Tests
shellcheckon yourPATH, runREPO_ROOT=<path to this branch> bash scripts/actionlint.sh. It printedWorkflows passed actionlint!.ruby -ryaml -e 'p YAML.load_file(".circleci/config.yml")["executors"]["default"]["docker"]'. It printed[{"image"=>"cimg/node:24"}], so the CircleCI config still parses.curl -s https://hub.docker.com/v2/repositories/cimg/node/tags/24. The24tag exists and has the same digest ascimg/node:24.22.2, the newest 24.x image today.rg --hidden -n nvmrc -g '!node_modules' -g '!.git'. There are no matches, so nothing expects.nvmrcto hold an exact version.nvm installand confirmnode -vprints the newest v24.x release.