Repository navigation
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
amyevans
marked this pull request as ready for review
November 9, 2026 22:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Updates node-forge from 1.3.1 to 1.4.2 in
example/package-lock.json. This closes all 11 open node-forge Dependabot alerts (fixed in 1.4.1). Lockfile only:selfsignedalready allows^1.node-forge reaches the example app through
react-scripts→webpack-dev-server→selfsigned, which uses it to make the dev server's self-signed certificate. It does not ship in the library.1.4.3 is the newest release, but it is under 7 days old, so
min-release-age=7excludes it.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/701679
AI Tests
npm ls node-forge --all --package-lock-onlyinexample/resolves only 1.4.2.selfsigned@2.1.1withnode-forge@1.4.2generated a 2048-bit certificate and key.Tests
example/, runnpm ci.npm run web.QA
NA
– written by Claude on Amy's behalf