Repository navigation
feat(agent): refuse to replace the agent root CA without --new-agent-root - #185
Merged
Merged
Conversation
…root
Every enrolled fog-agent pins pki/root.pem. If pki/ was lost, setup made a
new root without a word and every agent stopped trusting the server.
- The database records the root's SHA-256 fingerprint (Setting
FOG_AGENT_ROOT_FINGERPRINT). It is public; no key goes in the database.
- ensurePki(dir, {expectedRoot}) throws E_AGENT_ROOT_MISSING or
E_AGENT_ROOT_MISMATCH before it writes anything.
- setupPki (used by setup and setup:dev) passes the recorded fingerprint,
prints how to restore pki/, and makes a new root only with
`npm run setup -- --new-agent-root` (old files renamed with a timestamp).
- signCsr refuses (notConfigured) when root.pem differs from the record.
- docs/install.md: back up pki/ with the database; the flag and its cost.
An install set up before this change records its current root on the next
setup run.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Every enrolled fog-agent pins
pki/root.pem.pki/is git-ignored, so a reinstall that wipes the app folder used to make a new root silently, and every enrolled agent would stop trusting the server. This lands before agent enrollment ships, so no agent can enroll under a root that can be silently replaced.What
FOG_AGENT_ROOT_FINGERPRINT. Public data only; no key goes in the database.ensurePki(dir, {expectedRoot})throwsE_AGENT_ROOT_MISSING/E_AGENT_ROOT_MISMATCHbefore any write, and returns{rootFingerprint}.setupPki(new, intools/setup/pki.js; bothnpm run setupandsetup:devuse it): checks against the record, prints what is wrong, how to restorepki/, and the escape hatch.npm run setup -- --new-agent-rootrenames the old CA files with a timestamp and makes a new root on purpose.signCsrexitsnotConfiguredwhenroot.pemdoes not match the record.docs/install.md: "Agent certificate authority" section (back uppki/with the database).A passphrase-encrypted backup of the CA keys in the database is a separate, later PR.
Verification
npm test: 256 passing.npm run test:install: all checks pass.pki.jsandsign-csr.js, the new tests fail (13 failing); restored, all pass.config/andpki/: both exit 0.setup:devwithpki/moved away: prints the restore message and exits 1; nothing is created.Reviews (opus): spec and standards, two rounds; last findings (a spacing nit, an alias, the
stampexport dropped from the brief) fixed.🤖 Generated with Claude Code