Repository navigation
fix(agent): serve only agent paths on the agent mTLS port - #191
Merged
Merged
Conversation
The agent listener answered every route of the app, the admin UI too.
It now passes only /agent/v1/* and the two CA files to the app. Every
other path gets 404 {"error":"not found"}. The check reads the raw
path with no decoding, refuses any character outside [A-Za-z0-9/_.-],
and requires a normalized path, so /%61gent/v1/poll cannot reach /login.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The fog-agent mTLS listener passed every request to the app. The admin UI,
/loginand/api/v1/*answered on the agent port.Change
api/hooks/agent-tls/index.js:agentPath(url)allows only/agent/v1/*and the two CA files (/management/other/ca.cert.pem,ca.cert.der). Every other path gets 404{"error":"not found"}before Express runs, so no session is made.[A-Za-z0-9/_.-]and requirespath.posix.normalize(raw) === raw. So/%61gent/v1/poll,%2F,..,\\and NUL get 404.docs/install.mddescribes the restricted port.Test
npm test: 436 passing. The unit tests list allowed and refused paths, the encoded bypasses included. The integration test checks/login,/and/api/v1/hostfor 404 over mTLS with no cookie and no new session, and the CA file for 200./%61gent/v1/poll true !== false).🤖 Generated with Claude Code