Repository navigation
fix(data): remove 21 added records that duplicate existing ones - #398
Merged
Merged
Conversation
19 phones and 2 SoCs added in the last two additions already exist under a longer or differently spelled name (for example htc-p4000 next to htc-p4000-htc-titan-100). The older records stay; the new copies go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Closes #296
Removes 21 records added by the last additions (#396 and #397) that turned out to duplicate records already in the dataset under a longer or differently spelled name. The earlier duplicate check compared whole names; a second check that compares name tokens within the same brand found these. The older records stay untouched.
Removed
Phones (19), each next to an existing record of the same device, for example:
htc-p4000htc-p4000-htc-titan-100alcatel-one-touch-980alcatel-one-touch-ot-980motorola-devourmotorola-devour-a555-motorola-calgaryzte-engage-ltzte-n8000-engage-ltsamsung-i5500i5500-galaxy-5meizu-mx4-ubuntu-editionmeizu-mx4-ubuntu-edition-td-lteThe others:
alcatel-one-touch-990,blackberry-tour,htc-iris,htc-s720,htc-thunderbolt,huawei-nova-y70,kyocera-urbano-progresso,lg-optimus-l4-ii,meizu-pro-5-ubuntu-edition,microsoft-lumia-430,motorola-droid-bionic,spice-dream-uno,zte-groove.SoCs (2):
apple-a16-apl1w10(already present asapple-a16-bionic-apl1010-apl1w10) andmediatek-helio-g91-mt6769g(already present asmediatek-helio-g91-ultra).No record references any of the removed slugs. None of them has been released to
main.Source
Not a new-data change.
Checklist
develop(mainonly moves through release PRs)python -m app.validatepasses locally