Repository navigation
fix(data): move 109 records to the folders the layout documents - #400
Merged
Merged
Conversation
The README documents laptop/<brand>/<year>/<base_model>/<slug>.json. These 44 Apple and Microsoft records sat directly in the year folder; each already carries a base_model_slug, so the file moves into the folder of that name. Content is unchanged.
The year folder is documented as the year of release_date. These records sat in a later (or, for one, earlier) year folder than their date. Each date was checked against the record's sources and its family before moving; content is unchanged. Five records with the same mismatch are left in place because the date itself looks wrong: the two Snapdragon 835 MSM8998 records, Core Ultra 5 135U, Core Ultra 7 155U and Zhaoxin KX-7000.
The file named @GetTechAPI/maintainers, a team that does not exist, so no path had an owner. Name @Seungpyo1007 instead.
TechEngineBot
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Closes #296
The README documents one folder layout per category, and 109 records did not follow it. This moves them; no record's content changes and no slug changes, so API paths stay the same.
Changes
base_model_slug.release_date.All 109 moves are pure renames (similarity 100%).
Left for a separate look
Five records sit in a folder that differs from their date, but the date itself looks wrong, so neither was touched:
qualcomm-msm8998-snapdragon-835andqualcomm-snapdragon-835-msm8998(dated 2017-12-05),core-ultra-5-135uandcore-ultra-7-155u(dated 2024-01-09 while their siblings say 2023-12-14), andkx-7000-kh-40000.Source
Not a new-data change.
Checklist
develop(mainonly moves through release PRs)python -m app.validatepasses locallydata/<category>/<...>/<slug>.jsonpath