Repository navigation
fix(data/cpu): store two fractional TDP values as whole watts - #401
Merged
Merged
Conversation
tdp_w is an integer field in the API schema. Pentium 3561Y (11.5 W) and AMD Z-01 (5.9 W) were added with fractional values, which the API serialiser rejects; they are rounded to 12 and 6.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Closes #296
tdp_wis an integer in the API schema. Two processors added in #395 carry fractional values, which the bundled validator accepts but the engine's serialiser rejects, so generating the API fromdevelopfails (seen in TechEngine's test run against this dataset).pentium-3561yz-01No other CPU, GPU or SoC record holds a fractional value in an integer field.
Source
The cited Wikipedia lists give 11.5 W and 5.9 W; the values are rounded to fit the field.
Checklist
develop(mainonly moves through release PRs)python -m app.validatepasses locally