Repository navigation
chore: bump TechEngine submodule to c0743ba - #402
Merged
Merged
Conversation
Brings the engine validator's integer-field check to PR checks, and the engine's site and Docker fixes. collect.yml's reusable workflows move to the same commit.
TechEngineBot
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Closes #297
Moves the TechEngine pin from ff4e11e to c0743ba (TechEngine 135 and 136). The engine validator that runs in PR checks now rejects fractional numbers, booleans and strings in fields the API types as integers. Two such values reached
developin #395 and only failed when the API was generated; with this pin a PR like that fails its own checks.Changes
TechEnginegitlink →c0743ba9382dfed2880f0de82adc704cc8f7c4de.uses:lines incollect.ymlmove to the same commit.Checks
With the new engine: bundled validator, engine validator over the whole dataset (run without installing the engine, as PR checks do) and the integrity gate all pass locally.
Checklist
develop(mainonly moves through release PRs)python -m app.validatepasses locally