Repository navigation
fix(cli): bound searches and keep reviews productive - #363
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repository searches could expose sensitive files, print compiled binary data, consume unbounded memory, and continue after cancellation. Grep now filters sensitive paths and nonregular files, rejects binaries and files above 10 MiB, checks cancellation during traversal and scanning, and caps line previews and total results. CLI output explains skipped files and truncated searches.
Named Go build diagnostics such as
go env GOTOOLCHAIN GOFLAGS GOROOTnow work through Bash and/run. The exception is restricted to literal diagnostic names in each shell segment; bulk environment dumps, credential-bearing Go settings, mutations, expansions, and appended dump commands remain blocked.Long reviews no longer stop at a hidden 500K cumulative input/output ceiling. Explicit session budgets still apply, and prompt growth only triggers the detector when tool activity declines. Stops give a short reason and explain how to continue in the current conversation instead of printing a debug recommendation to discard context.
Validation: all 156 Go packages passed with the race detector; CLI
/runregression tests passed with the race detector; formatting, vet, architecture boundaries, lint (zero issues), and build passed. Regression tests cover sensitive-file filtering, binary/size/output bounds, cancellation before and during search, environment-dump bypass attempts, reviews exceeding 500K tokens, and terminal stop events.reflect verifyalso passed all 156 Go package checks. Its overall result remains failed because the existing local security event log has a broken hash chain at entry 200; this change does not modify historical audit records.