Skip to content

Use locale time format in welcome page event date pickers - #1489

Open
devin-ai-integration[bot] wants to merge 1 commit into
developfrom
devin/1794263240-welcome-time-format
Open

devin-ai-integration[bot] wants to merge 1 commit into
developfrom
devin/1794263240-welcome-time-format

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

What changes I've made

The start/end DateTimePickers on the welcome (first event) page in frontend/src/components/routes/welcome/index.tsx hardcoded timePickerProps.format: '12h'. They now use getTimePickerFormat(), the same locale-derived format DateTimeField uses when editing an event.

Why I've made these changes

Fixes #1165: creating an event showed an AM/PM time picker, but editing the same event showed a 24h picker for locales that use 24h time (e.g. German).

How I've tested these changes

npx tsc --noEmit passes. I haven't tested it in the UI.

Checklist

  • I have read the contributing guidelines.
  • My code follows the coding standards of the project.
  • I have tested my changes, and they work as expected.
  • I understand that this PR will be closed if I do not follow the contributor guidelines and if this PR template is left unedited.

Link to Devin session: https://app.devin.ai/sessions/ddd85fd0007f4b41b598710d631233d5
Open in Devin Desktop: https://app.devin.ai/desktop/session/ddd85fd0007f4b41b598710d631233d5?variant=devin
Requested by: @daveearley


🟢 Devin Review found nothing to fix · View findings

Devin Review

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@devin-ai-integration

Copy link
Copy Markdown
Author

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

✅ E2E smoke tests: Everything passed.

Mode Result ✅ Passed ❌ Failed ⚠️ Flaky ⏭️ Skipped ⏱️ Duration
Self-hosted ✅ Passed 113 0 0 0 2m 52s

Open the run

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛Entering the date differs: creating a new event versus copying/editing existing event

1 participant