Repository navigation
Use locale time format in welcome page event date pickers - #1489
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Contributor
✅ E2E smoke tests: Everything passed.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes I've made
The start/end
DateTimePickers on the welcome (first event) page infrontend/src/components/routes/welcome/index.tsxhardcodedtimePickerProps.format: '12h'. They now usegetTimePickerFormat(), the same locale-derived formatDateTimeFielduses when editing an event.Why I've made these changes
Fixes #1165: creating an event showed an AM/PM time picker, but editing the same event showed a 24h picker for locales that use 24h time (e.g. German).
How I've tested these changes
npx tsc --noEmitpasses. I haven't tested it in the UI.Checklist
Link to Devin session: https://app.devin.ai/sessions/ddd85fd0007f4b41b598710d631233d5
Open in Devin Desktop: https://app.devin.ai/desktop/session/ddd85fd0007f4b41b598710d631233d5?variant=devin
Requested by: @daveearley
🟢 Devin Review found nothing to fix · View findings