Repository navigation
fix(grafana): count only failed conditions as failures - #228
Merged
Merged
Conversation
kube-state-metrics exports Unknown conditions as 0 like False. Ready is Unknown while a resource is reconciled (ReconcileStarted), and the components of archived repositories are Unknown (Skipped). The dashboard counted both as failures, e.g. seven constant failing components for every archived repository. The panels now select failures by reason: ReconcileFailed or UserActionRequired for Ready, SyncFailed or UserActionRequired for the components.
KRaffael
approved these changes
Nov 20, 2026
Contributor
|
🎉 This PR is included in version 0.12.2 🎉 The release is available on GitHub release and as container image |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
kube-state-metrics exports both
FalseandUnknownconditions as0, but the "Managed resources" panels treated every0as a failure. Conditions areUnknownin two harmless cases:Readywhile a resource is reconciled (reasonReconcileStarted), which caused short false spikes in the not-ready panels.Skipped), which showed up as seven constant "failing components" for every archived repository.The panels now select failures by reason:
ReadywithReconcileFailedorUserActionRequiredSyncFailedorUserActionRequiredSkipped components remain visible in the "Skipped components" panel.
docs/monitoring.mdnow explains theUnknownhandling.Type of Change
Checklist
make codegenNo code changes.
mkdocs build --strictpasses.Related Issues