Skip to content

fix(grafana): count only failed conditions as failures - #228

Merged
tstollin merged 1 commit into
mainfrom
dashboard-condition-reasons
Nov 20, 2026
Merged

tstollin merged 1 commit into
mainfrom
dashboard-condition-reasons

Conversation

@tstollin

Copy link
Copy Markdown
Contributor

Description

kube-state-metrics exports both False and Unknown conditions as 0, but the "Managed resources" panels treated every 0 as a failure. Conditions are Unknown in two harmless cases:

  • Ready while a resource is reconciled (reason ReconcileStarted), which caused short false spikes in the not-ready panels.
  • The components of archived repositories (reason Skipped), which showed up as seven constant "failing components" for every archived repository.

The panels now select failures by reason:

Panels Reasons
Not-ready resources (stat, time series, table) Ready with ReconcileFailed or UserActionRequired
Failing components SyncFailed or UserActionRequired

Skipped components remain visible in the "Skipped components" panel. docs/monitoring.md now explains the Unknown handling.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Chore (refactoring, CI changes, dependency updates, etc.)

Checklist

  • My commits follow the Conventional Commits format
  • I have added/updated unit tests for any new or changed templates
  • I have updated documentation (README, CONTRIBUTING, values comments) if needed
  • I have updated the generated files using make codegen

No code changes. mkdocs build --strict passes.

Related Issues

kube-state-metrics exports Unknown conditions as 0 like False. Ready is
Unknown while a resource is reconciled (ReconcileStarted), and the
components of archived repositories are Unknown (Skipped). The dashboard
counted both as failures, e.g. seven constant failing components for every
archived repository. The panels now select failures by reason:
ReconcileFailed or UserActionRequired for Ready, SyncFailed or
UserActionRequired for the components.
@tstollin
tstollin requested a review from a team as a code owner November 18, 2026 06:02
@tstollin
tstollin merged commit 1410a1b into main Nov 20, 2026
8 checks passed
@tstollin
tstollin deleted the dashboard-condition-reasons branch November 20, 2026 06:34
@github-actions

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 0.12.2 🎉

The release is available on GitHub release and as container image ghcr.io/interhyp/git-hubby:0.12.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants