Repository navigation
Keep coroutine frames on the thread running the body - #2167
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the coroutine part (runtime async only) of, thus resolves #2133. The solution is similar to #2146: the frame is popped at suspension points, and re-applied on resume. Unlike in the generator case where suspension points are yielding back to the caller, await points are awaited forward, hence not visible to the caller. So the mechanism is diferent: it uses
IObserverhook in the DLR (IronLanguages/dlr#380) to get notified about the suspenssion points and takes appropriate action. Async generator has both types of suspension points so it uses the sameIObservermechanism as the coroutine.