Skip to content

test: wait for menu transitions before dismissal - #1020

Merged
PaulHax merged 1 commit into
Kitware:mainfrom
PaulHax:menu-dismissal-readiness
Nov 8, 2026
Merged

PaulHax merged 1 commit into
Kitware:mainfrom
PaulHax:menu-dismissal-readiness

Conversation

@PaulHax

@PaulHax PaulHax commented Nov 7, 2026

Copy link
Copy Markdown
Collaborator

The OCT navigation and oblique windowing E2E tests can send Escape while the Window & Level popup is still opening. On macOS, the menu then remains visible and the closure assertion times out.

Wait for the linked menu content to be displayed and stable before closeMenu() sends Escape, and use the shared menu helpers for the oblique test's open/close sequence. The tests still send one Escape and assert both the collapsed activator and hidden content.

This extracts 296303c from #1003 so the shared test fix can land independently of adaptive volume rendering.

Evidence:

Validation:

  • Production build on the unchanged application source passed.
  • Changed-file Prettier and ESLint, vue-tsc --noEmit, repository quality checks, and git diff --check passed.
  • Local E2E execution could not start Chrome because the cloud environment blocks its required Unix socket. This PR runs the full E2E matrix on current main.

Extract the shared menu readiness fix from adaptive-volume-rendering so
OCT and oblique windowing E2E tests can use it independently.

Original-commit: 296303c
@netlify

netlify Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for volview-dev ready!

Name Link
🔨 Latest commit 7119a50
🔍 Latest deploy log https://app.netlify.com/projects/volview-dev/deploys/6aef900a79cee9020fdb4a0c
😎 Deploy Preview https://deploy-preview-1020--volview-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@PaulHax
PaulHax marked this pull request as ready for review November 8, 2026 15:37
@PaulHax
PaulHax merged commit 95f8a8c into Kitware:main Nov 8, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant