Repository navigation
test: wait for menu transitions before dismissal - #1020
Merged
Merged
Conversation
Extract the shared menu readiness fix from adaptive-volume-rendering so OCT and oblique windowing E2E tests can use it independently. Original-commit: 296303c
✅ Deploy Preview for volview-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OCT navigation and oblique windowing E2E tests can send Escape while the Window & Level popup is still opening. On macOS, the menu then remains visible and the closure assertion times out.
Wait for the linked menu content to be displayed and stable before
closeMenu()sends Escape, and use the shared menu helpers for the oblique test's open/close sequence. The tests still send one Escape and assert both the collapsed activator and hidden content.This extracts 296303c from #1003 so the shared test fix can land independently of adaptive volume rendering.
Evidence:
Validation:
vue-tsc --noEmit, repository quality checks, andgit diff --checkpassed.