Repository navigation
Read the reaction type Core sends; real industry labels in examples (2.3.22) - #13
Merged
Merged
Conversation
Core returns a person's reactions with the field `type`, but TReaction declared `reactionType`, so typed consumers always read undefined. The JSDoc examples for searchCompanies, searchPeople and retrieveConnections used "Technology" and "Software", which are not LinkedIn industry labels; Core types the value into LinkedIn's typeahead, so a copied example silently got the first suggestion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TReaction.reactionType→type. Core returns a person's reactions as{ postUrl, time, type }(IStReaction), so the declaredreactionTypewas always undefined at runtime.searchCompanies,searchPeopleandretrieveConnectionsused"Technology"/"Software", which are not LinkedIn industry labels. Core types the value into LinkedIn's typeahead, so a copied example silently got the first suggestion. They now use"Software Development"and"IT Services and IT Consulting".Checks: lint, build, jest 82/82.