Skip to content

CI: ignore the picomatch advisory in the Bun audits - #1639

Merged
AnthonyRonning merged 2 commits into
masterfrom
ci/quiet-picomatch-advisory
Nov 18, 2026
Merged

AnthonyRonning merged 2 commits into
masterfrom
ci/quiet-picomatch-advisory

Conversation

@AnthonyRonning

@AnthonyRonning AnthonyRonning commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Why

sdk-ts has failed on master since November 17, and with it ci-ok on every run that selects the SDK lane (latest master failure). The cause is bun audit reporting GHSA-fc5q-39xc-vjpf, a regular-expression denial of service in picomatch. The advisory covers every release through 4.0.7, the latest, so there is nothing to upgrade to. The same build script runs before an npm SDK publish, so that is blocked too, and the nightly audit fails for the SDK, the Research frontend and Auth.

Exposure

  • picomatch is in those three lockfiles only through build and lint tooling: Vite, typescript-eslint, Tailwind, vite-plugin-dts and the TanStack router plugin.
  • No source file imports picomatch or another glob matcher, and none of the published SDK's eight runtime dependencies reach it.
  • The attack needs control of the glob pattern. Ours come from this repository's own Vite, Tailwind, TypeScript and ESLint configuration, so changing them takes commit access.
  • The worst outcome is a hung build or dev server. The advisory is availability-only.

This rests on the dependency graph and source imports. Built bundles were not inspected.

Change

  • scripts/ci/build-sdk-publish.sh and .github/workflows/nightly.yml pass --ignore=GHSA-fc5q-39xc-vjpf to bun audit. Every other advisory still fails both.
  • A comment at each call site gives the reason and the removal condition: take the flag out of both places once a fixed picomatch is published.

No manifest or lockfile changes.

Checked locally

  • bun audit --audit-level=high in all five nightly projects, with and without the flag: the SDK, Research frontend and Auth go from 1 high to clean, and the two updates services are clean either way.
  • The flag is specific: a made-up GHSA id still fails, and so does the CVE id (bun audit --ignore matches the GHSA id only).
  • ./scripts/ci/build-sdk-publish.sh npm: install, audit, format check, build, 333 tests and pack passed. The last step, check-sdk-package-consumers.py, did not run on this Mac because python3 is not available inside the SDK Nix shell here. CI's sdk-ts covers it.
  • plan.py lint and plan.py run repo pass, and CI's sdk-ts passed on the first commit, which has the same audit lines.

Merge note

This touches scripts/ci/ and .github/, which are outside the paths that leave Research release evidence usable, so do not merge it between a Research version bump and its release.

🤖 Generated with Claude Code

AnthonyRonning and others added 2 commits November 17, 2026 19:48
GHSA-fc5q-39xc-vjpf (picomatch regular-expression denial of service) covers
every picomatch release through 4.0.7, the latest, so no upgrade clears it.
Since November 17 it has failed `sdk-ts`, and with it `ci-ok`, on every run
that selects the SDK lane, and it fails the nightly audit for the SDK,
Research frontend and Auth.

picomatch reaches those three lockfiles only through build and lint tooling
(Vite, typescript-eslint, Tailwind, vite-plugin-dts, the TanStack router
plugin). No source file imports a glob matcher, the published SDK's runtime
dependencies do not reach it, and the patterns it matches come from this
repository's own configuration.

Pass `--ignore=GHSA-fc5q-39xc-vjpf` in both audit call sites and record the
exception, its reasons and its removal condition in docs/ci.md. Every other
advisory still fails the audits.

Co-Authored-By: Claude <noreply@anthropic.com>
Drop the docs/ci.md section. The two audit call sites now carry the reason
and the removal condition themselves.

Co-Authored-By: Claude <noreply@anthropic.com>
@AnthonyRonning
AnthonyRonning merged commit 62f83f0 into master Nov 18, 2026
22 checks passed
@AnthonyRonning
AnthonyRonning deleted the ci/quiet-picomatch-advisory branch November 18, 2026 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant