Repository navigation
CI: ignore the picomatch advisory in the Bun audits - #1639
Merged
Merged
Conversation
GHSA-fc5q-39xc-vjpf (picomatch regular-expression denial of service) covers every picomatch release through 4.0.7, the latest, so no upgrade clears it. Since November 17 it has failed `sdk-ts`, and with it `ci-ok`, on every run that selects the SDK lane, and it fails the nightly audit for the SDK, Research frontend and Auth. picomatch reaches those three lockfiles only through build and lint tooling (Vite, typescript-eslint, Tailwind, vite-plugin-dts, the TanStack router plugin). No source file imports a glob matcher, the published SDK's runtime dependencies do not reach it, and the patterns it matches come from this repository's own configuration. Pass `--ignore=GHSA-fc5q-39xc-vjpf` in both audit call sites and record the exception, its reasons and its removal condition in docs/ci.md. Every other advisory still fails the audits. Co-Authored-By: Claude <noreply@anthropic.com>
Drop the docs/ci.md section. The two audit call sites now carry the reason and the removal condition themselves. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
sdk-tshas failed on master since November 17, and with itci-okon every run that selects the SDK lane (latest master failure). The cause isbun auditreporting GHSA-fc5q-39xc-vjpf, a regular-expression denial of service in picomatch. The advisory covers every release through 4.0.7, the latest, so there is nothing to upgrade to. The same build script runs before an npm SDK publish, so that is blocked too, and the nightly audit fails for the SDK, the Research frontend and Auth.Exposure
vite-plugin-dtsand the TanStack router plugin.This rests on the dependency graph and source imports. Built bundles were not inspected.
Change
scripts/ci/build-sdk-publish.shand.github/workflows/nightly.ymlpass--ignore=GHSA-fc5q-39xc-vjpftobun audit. Every other advisory still fails both.No manifest or lockfile changes.
Checked locally
bun audit --audit-level=highin all five nightly projects, with and without the flag: the SDK, Research frontend and Auth go from 1 high to clean, and the two updates services are clean either way.bun audit --ignorematches the GHSA id only)../scripts/ci/build-sdk-publish.sh npm: install, audit, format check, build, 333 tests and pack passed. The last step,check-sdk-package-consumers.py, did not run on this Mac becausepython3is not available inside the SDK Nix shell here. CI'ssdk-tscovers it.plan.py lintandplan.py run repopass, and CI'ssdk-tspassed on the first commit, which has the same audit lines.Merge note
This touches
scripts/ci/and.github/, which are outside the paths that leave Research release evidence usable, so do not merge it between a Research version bump and its release.🤖 Generated with Claude Code