Repository navigation
Generate the Base Minerals 1.10 ore models - #38
Merged
SkyBlade1978 merged 1 commit intoNov 8, 2026
Merged
SkyBlade1978 merged 1 commit into
SkyBlade1978 merged 1 commit into
Conversation
Use KiriCattus's overlays on vanilla stone and keep support for full ore textures. Check the generated block and inventory models in the packaged client.
|
|
SkyBlade1978
merged commit Nov 8, 2026
caa470f
into
MinecraftModDevelopmentMods:master-1.10.2
5 of 6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows the Modern Metals update. The build now generates the ore models, so the seven ores use KiriCattus's overlays on vanilla stone. A full ore texture still works when an overlay is missing.
The local build, resource and artifact checks, and Eclipse preparation passed. The clean offline build reproduced all three jars. The packaged client checked all seven overlay models and all seven solid-texture fallbacks in the block and inventory views. The quick server check also passed with repeat and reload.
Wrapper validation, CodeQL and cold Forge bootstrap passed on the fork and on this PR. Both packaged jobs passed the fresh-world, disabled-material and OS3 import cases. They stopped at the same OS1 reload assertion as the base branch, where OreSpawn adds a second lithium rule. Fork run · PR run · Base branch run