Repository navigation
Finish Modern Metals for Minecraft 1.10.2 - #131
Merged
SkyBlade1978 merged 3 commits intoNov 7, 2026
Merged
SkyBlade1978 merged 3 commits into
SkyBlade1978 merged 3 commits into
Conversation
SkyBlade1978
merged commit Nov 7, 2026
8079609
into
MinecraftModDevelopmentMods:master-1.10.2
6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This finishes the 1.10.2 release. The ores use KiriCattus's overlays, the settings screens have translations, and multiplayer checks that the client and server use the same Fantasy Level. There's also a switch for new villager trades.
I've added support for the old door, fishing rod, horse armor, alloy ore and molten aluminum brass IDs from 0.11.0. The upgrade checks cover copies made with both public 1.10.2 releases. All 20 ores also resolved through the Base Metals registry and both the baseSteam and baseElectric crusher lookups.
The README covers installation and old worlds, and the changelog has the player-facing changes. The release action follows Base Metals and checks the exact game jar before publishing. The build also packs the legacy API name list the same way on Windows and Linux.
The fork build, CodeQL and wrapper checks passed. The packaged game jar matches the one used for manual testing.