Repository navigation
NeuroScopeRawIO: use lfpSamplingRate for .lfp and .eeg files - #1967
Open
aaronkanzer wants to merge 1 commit into
Open
aaronkanzer wants to merge 1 commit into
aaronkanzer wants to merge 1 commit into
Conversation
zm711
reviewed
Nov 10, 2026
zm711
left a comment
Contributor
There was a problem hiding this comment.
This looks good to me and I'm temped to just merge, but would there ever be a case where we would have the lfp/eeg yet still want the AP band data ie the 20kHz sampling rate. I don't use this data so for my learning I would love to hear a bit more about the general use of these formats and why this format has both a downsampled and wide band sampling rates and when a user would want to use one or the other. For example I could also imagine making this an argument in the reader and letting the user choose which sampling rate to use.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a Neuroscope XML,
acquisitionSystem/samplingRateis the rate of the wideband.datfile. The downsampled.lfpand.eegfiles are written atfieldPotentials/lfpSamplingRate.NeuroScopeRawIOalways usessamplingRate, so LFP files get the wideband rate. Their times and durations come out too short by the ratio of the two rates, 16x for the common 20000 / 1250 Hz setup.Repro with
neuroscope/dataset_1from ephy_testing_data. The XML hassamplingRate20000 andlfpSamplingRate1250:Observed on 0.14.6 and master:
20000.0 10 0.0005Expected:
1250.0 10 0.008Fix: when the data file ends in
.lfpor.eegand the XML hasfieldPotentials/lfpSamplingRate, use that rate..datfiles are unchanged. A test covers both suffixes.