Repository navigation
A log file loader has one owner: the viewer's loader set - #56
Merged
Merged
Conversation
LogFileLoader was created with parent=self (the viewer's Qt children delete it) and its finished signal also queued deleteLater: two owners of one lifetime. cleanup() waited for the thread and dropped it, then the queued finished -> deleteLater ran in teardown on an object Qt had already torn down: segfault in test_visible_log_viewer_discovers_server_started_after_ initial_scan, which failed the 0.10.0 release run. Now the loader set owns it; a finished loader leaves the set and Python frees it; cleanup waits before clearing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016gZLdupVQyBzHTmHBC9Cyn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 0.10.0 release run segfaulted in test_visible_log_viewer_discovers_server_started_after_initial_scan teardown. LogFileLoader had two lifetime owners:
parent=self(Qt children) and a queuedfinished→deleteLater. cleanup() waited and dropped it; the queued deleteLater then ran in teardown on an object Qt had torn down (gdb: ~QObject from a DeferredDelete). Now the_file_loadersset is the one owner; no Qt parent, no deleteLater. tests/test_log_viewer_lifecycle.py: 11 passed (was a segfault at test 5).🤖 Generated with Claude Code
https://claude.ai/code/session_016gZLdupVQyBzHTmHBC9Cyn