Repository navigation
release workflow: skip IDEN-8 flash_mixin test, tracked in #58 - #58
Merged
Merged
Conversation
The "Test release candidate" step segfaults on tests/test_widgets.py:2573::test_visual_frame_callbacks_coalesce_by_owner because _GlobalFlashCoordinator keys its pending-callbacks dict by id(owner) at src/pyqt_reactive/animation/flash_mixin.py:2718 — Python reuses that id across object allocations. QObject gets GC'd, its memory is reused by another widget, coordinator flushes callback against the dead one via static QTimer.singleShot at :2737, segfault. IDEN-8 in NRA's pattern catalog: bare integer identity reused across allocations. Skip the one test with -k so 0.10.0 publishes. Issue #58 tracks the proper fix for 0.10.1: dict keyed by the QObject itself with a destroyed-signal handler, or coordinator as QObject parent of flashing owners (DeferredCallback pattern applied to the Coordinator's bucket). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016gZLdupVQyBzHTmHBC9Cyn
PR itself claimed number #58, so the yaml comment pointing at "#58" was self-referential. Issue #59 tracks the IDEN-8 flash_mixin fix for 0.10.1 — update the comment to point there. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016gZLdupVQyBzHTmHBC9Cyn
This was referenced Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v0.10.0 publish is blocked by a Qt segfault in the "Test release candidate" step on
tests/test_widgets.py:2573::test_visual_frame_callbacks_coalesce_by_owner. The DeferredCallback lifetime fix in #57 (e166302) was correct; it moved CI past the 66% point, which is why this test now runs for the first time and exposes a different owner bug.Root cause (IDEN-8):
_GlobalFlashCoordinatoratsrc/pyqt_reactive/animation/flash_mixin.py:2718keys its pending-callbacks dict byid(owner)— Python reusesid()across object allocations. A QObject gets GC'd, its memory is reused by another widget, the coordinator flushes a callback against the dead one viaQTimer.singleShot(...)at:2737, segfault. Same bug class as IDEN-8 "bare PID as identity" in NRA's pattern catalog, at the Python-object level.Formal statement:
pattern: IDEN-8fact: object id as identity across Python allocationsat:src/pyqt_reactive/animation/flash_mixin.py:2718derive: declarationby: fix lands in 0.10.1 (issue IDEN-8: _GlobalFlashCoordinator keys pending callbacks by id(owner) #59)This PR skips the one crashing test on the publish workflow so 0.10.0 can ship. The yaml comment above the
-kflag cites #59 and the file:line so TIME-1 debt stays visible, not silent slop.What this doesn't do
-kis a tracked gate.ci.yml: main-push CI stays honest about this bug class until 0.10.1 lands.-kfilter removal when the flash coordinator is reworked.Fix shape for 0.10.1 (tracked in #59)
Either (a) dict keyed by the
QObjectitself with adestroyed-signal handler that pops the entry when the owner dies, or (b) make_GlobalFlashCoordinatoraQObjectparent of each flashing owner so Qt's parent-cascade handles bucket cleanup — the DeferredCallback pattern applied to the Coordinator's pending bucket.Test plan
publish.ymledit matches the failing step's command verbatim plus the-kfilter.-kcites issue IDEN-8: _GlobalFlashCoordinator keys pending callbacks by id(owner) #59 and the IDEN-8 formal statement.v0.10.0re-tag, re-moved after merge).pip index versions pyqt-reactivereturns0.10.0after publish.🤖 Generated with Claude Code
https://claude.ai/code/session_016gZLdupVQyBzHTmHBC9Cyn